--- /dev/null
+Return-Path: <sojkam1@fel.cvut.cz>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 55F48431FD7\r
+ for <notmuch@notmuchmail.org>; Sun, 2 Nov 2014 01:35:05 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id WZ7WKQDkcHG3 for <notmuch@notmuchmail.org>;\r
+ Sun, 2 Nov 2014 01:34:58 -0800 (PST)\r
+Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])\r
+ by olra.theworths.org (Postfix) with ESMTP id BA6A1431FAF\r
+ for <notmuch@notmuchmail.org>; Sun, 2 Nov 2014 01:34:57 -0800 (PST)\r
+Received: from localhost (unknown [192.168.200.7])\r
+ by max.feld.cvut.cz (Postfix) with ESMTP id 9A79019F2F4D;\r
+ Sun, 2 Nov 2014 10:34:49 +0100 (CET)\r
+X-Virus-Scanned: IMAP STYX AMAVIS\r
+Received: from max.feld.cvut.cz ([192.168.200.1])\r
+ by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new,\r
+ port 10044)\r
+ with ESMTP id ta9Icm_g9ktY; Sun, 2 Nov 2014 10:34:44 +0100 (CET)\r
+Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])\r
+ by max.feld.cvut.cz (Postfix) with ESMTP id 7035619F2F50;\r
+ Sun, 2 Nov 2014 10:34:43 +0100 (CET)\r
+User-Agent: Kaiten Mail\r
+In-Reply-To: <87d2963q87.fsf@qmul.ac.uk>\r
+References: <1414792441-29555-1-git-send-email-sojkam1@fel.cvut.cz>\r
+ <1414792441-29555-7-git-send-email-sojkam1@fel.cvut.cz>\r
+ <87r3xnu3dn.fsf@qmul.ac.uk> <87bnoqbexm.fsf@steelpick.2x.cz>\r
+ <87d2963q87.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Transfer-Encoding: 8bit\r
+Content-Type: text/plain;\r
+ charset=UTF-8\r
+Subject: Re: [PATCH v6 6/7] cli: search: Add --output=count\r
+From: Michal Sojka <sojkam1@fel.cvut.cz>\r
+Date: Sun, 02 Nov 2014 10:34:37 +0100\r
+To: Mark Walters <markwalters1009@gmail.com>,notmuch@notmuchmail.org\r
+Message-ID: <b1fb8387-6ae4-4f9c-aee6-f4758f010751@email.android.com>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 02 Nov 2014 09:35:05 -0000\r
+\r
+\r
+\r
+On 2. listopadu 2014 10:29:28 CET, Mark Walters <markwalters1009@gmail.com> wrote:\r
+>\r
+>Hi\r
+>\r
+>On Sun, 02 Nov 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+>> On Sat, Nov 01 2014, Mark Walters wrote:\r
+>>> On Fri, 31 Oct 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+>>>> This output can be used with --output=recipients or --output=sender\r
+>>>> and in addition to the addresses, it prints how many times was each\r
+>>>> address encountered during search.\r
+>>>\r
+>>> Hi\r
+>>>\r
+>>> I have a couple comments on this patch.\r
+>>>\r
+>>>> ---\r
+>>>> completion/notmuch-completion.bash | 2 +-\r
+>>>> completion/notmuch-completion.zsh | 2 +-\r
+>>>> doc/man1/notmuch-search.rst | 9 +++++--\r
+>>>> notmuch-search.c | 51\r
+>++++++++++++++++++++++++++++++++------\r
+>>>> 4 files changed, 52 insertions(+), 12 deletions(-)\r
+>>>>\r
+>>>> diff --git a/completion/notmuch-completion.bash\r
+>b/completion/notmuch-completion.bash\r
+>>>> index cfbd389..39cd829 100644\r
+>>>> --- a/completion/notmuch-completion.bash\r
+>>>> +++ b/completion/notmuch-completion.bash\r
+>>>> @@ -294,7 +294,7 @@ _notmuch_search()\r
+>>>> return\r
+>>>> ;;\r
+>>>> --output)\r
+>>>> - COMPREPLY=( $( compgen -W "summary threads messages files\r
+>tags sender recipients" -- "${cur}" ) )\r
+>>>> + COMPREPLY=( $( compgen -W "summary threads messages files\r
+>tags sender recipients count" -- "${cur}" ) )\r
+>>>> return\r
+>>>> ;;\r
+>>>> --sort)\r
+>>>> diff --git a/completion/notmuch-completion.zsh\r
+>b/completion/notmuch-completion.zsh\r
+>>>> index 3e52a00..d7e5a5e 100644\r
+>>>> --- a/completion/notmuch-completion.zsh\r
+>>>> +++ b/completion/notmuch-completion.zsh\r
+>>>> @@ -53,7 +53,7 @@ _notmuch_search()\r
+>>>> '--max-threads=[display only the first x threads from the\r
+>search results]:number of threads to show: ' \\r
+>>>> '--first=[omit the first x threads from the search\r
+>results]:number of threads to omit: ' \\r
+>>>> '--sort=[sort results]:sorting:((newest-first\:"reverse\r
+>chronological order" oldest-first\:"chronological order"))' \\r
+>>>> - '--output=[select what to output]:output:((summary threads\r
+>messages files tags sender recipients))'\r
+>>>> + '--output=[select what to output]:output:((summary threads\r
+>messages files tags sender recipients count))'\r
+>>>> }\r
+>>>> \r
+>>>> _notmuch()\r
+>>>> diff --git a/doc/man1/notmuch-search.rst\r
+>b/doc/man1/notmuch-search.rst\r
+>>>> index 42f17e4..ec89200 100644\r
+>>>> --- a/doc/man1/notmuch-search.rst\r
+>>>> +++ b/doc/man1/notmuch-search.rst\r
+>>>> @@ -96,9 +96,14 @@ Supported options for **search** include\r
+>>>> Like **sender** but for addresses from *To*, *Cc* and\r
+>>>> *Bcc* headers.\r
+>>>> \r
+>>>> + **count**\r
+>>>> + Can be used in combination with **sender** or\r
+>>>> + **recipients** to print the count of how many times was\r
+>>>> + the address encountered during search.\r
+>>>> +\r
+>>>> This option can be given multiple times to combine different\r
+>>>> - outputs. Currently, this is only supported for **sender** and\r
+>>>> - **recipients** outputs.\r
+>>>> + outputs. Currently, this is only supported for **sender**,\r
+>>>> + **recipients** and **count** outputs.\r
+>>>\r
+>>> It might be worth saying that the results will be slower if count is\r
+>>> specified.\r
+>>\r
+>> I wrote something like this in\r
+>> id:1414889400-30977-10-git-send-email-sojkam1@fel.cvut.cz.\r
+>>\r
+>>>\r
+>>>> ``--sort=``\ (**newest-first**\ \|\ **oldest-first**)\r
+>>>\r
+>>> I think sort works as expected if count is not specified, but does\r
+>not\r
+>>> with count. \r
+>>\r
+>> Agreed.\r
+>>\r
+>>> Maybe count can be done by doing two passes? \r
+>>\r
+>> What do you mean by pass?\r
+>\r
+>I mean iterating through the messages twice: so the first time would\r
+>fill in the count in the hash map, and the second iteration would print\r
+>the addresses.\r
+\r
+That's what the patch does. Only the second time it iterates the hash.\r
+\r
+Michal\r
+\r
+-- \r
+Odesláno z mého telefonu pomocí Kaiten Mail. Omluvte prosím mou stručnost.\r
projects / notmuch-archives.git / commitdiff