Re: [RFC] Add support for the Solaris platform

diff --git a/13/da3e972cf71ff0bfeb2c7dd84cea587ff40e49 b/13/da3e972cf71ff0bfeb2c7dd84cea587ff40e49
new file mode 100644 (file)
index 0000000..f899021
--- /dev/null
+++ b/13/da3e972cf71ff0bfeb2c7dd84cea587ff40e49
@@ -0,0 +1,122 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 503594196F0\r
+       for <notmuch@notmuchmail.org>; Thu,  3 Jun 2010 17:22:58 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.89\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5\r
+       tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]\r
+       autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id I09o0UGE-tQ4; Thu,  3 Jun 2010 17:22:48 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 01607431FC1;\r
+       Thu,  3 Jun 2010 17:22:48 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id A0D73568F2D; Thu,  3 Jun 2010 17:22:47 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Tomas Carnecky <tom@dbservice.com>, notmuch@notmuchmail.org\r
+Subject: Re: [RFC] Add support for the Solaris platform\r
+In-Reply-To: <1272654024-5254-1-git-send-email-tom@dbservice.com>\r
+References: <1272654024-5254-1-git-send-email-tom@dbservice.com>\r
+User-Agent: Notmuch/0.3.1-22-g1d528f8 (http://notmuchmail.org) Emacs/23.1.1\r
+       (i486-pc-linux-gnu)\r
+Date: Thu, 03 Jun 2010 17:22:47 -0700\r
+Message-ID: <87ocfreje0.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 04 Jun 2010 00:22:58 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Fri, 30 Apr 2010 21:00:24 +0200, Tomas Carnecky <tom@dbservice.com> wrot=\r
+e:\r
+> Like on Mac OS X, the linker doesn't automatically resolve\r
+> dependencies.\r
+\r
+Thanks for this fix, Tomas!\r
+\r
+I like the fix described above, but you seem to have sent a patch with\r
+three independent changes, only one of which was described. See below\r
+for what I've done...\r
+\r
+>  notmuch: $(notmuch_client_modules) lib/libnotmuch.a\r
+> -    $(call quiet,CXX $(CFLAGS)) $^ $(FINAL_LIBNOTMUCH_LDFLAGS) -o $@\r
+> +    $(call quiet,CXX $(CFLAGS)) $^ $(FINAL_NOTMUCH_LDFLAGS) -o $@\r
+\r
+That seems to be correct. Could you describe what problem you ran into\r
+that motivated you to find this fix? I have not committed this piece.\r
+\r
+> -printf "Checking for Mac OS X (for shared library)... "\r
+> +printf "Checking which platform we are on... "\r
+>  if [ `uname` =3D "Darwin" ] ; then\r
+> -    printf "Yes.\n"\r
+> -    mac_os_x=3D1\r
+> +    printf "Mac OS X.\n"\r
+> +    platform=3DMACOSX\r
+...\r
+> -ifeq ($(MAC_OS_X),1)\r
+> +ifeq ($(PLATFORM),MACOSX)\r
+>  LIBRARY_SUFFIX =3D dylib\r
+>  # On OS X, library version numbers go before suffix.\r
+>  LINKER_NAME =3D libnotmuch.$(LIBRARY_SUFFIX)\r
+\r
+That hunk was all described by your original commit message. So I've\r
+applied this part with your original commit message and will be pushing\r
+it soon.\r
+\r
+> +/* Helper functions to test if a given dirent is of a certain type\r
+> + */\r
+> +static int\r
+> +_is_reg(const char *path, struct dirent *entry)\r
+...\r
+> @@ -372,7 +426,7 @@ add_files_recursive (notmuch_database_t *notmuch,\r
+>=20=20\r
+>          if (! S_ISREG (st.st_mode))\r
+>              continue;\r
+> -    } else if (entry->d_type !=3D DT_REG) {\r
+> +    } else if (!_is_reg(path, entry)) {\r
+>          continue;\r
+>      }\r
+\r
+This all might be well and good, but is also not described by the commit\r
+message. So I have not committed this either. If you resend with an\r
+actual description of the change, I'll be happy to take a closer look.\r
+\r
+Thanks again,\r
+\r
+=2DCarl\r
+\r
+=2D-=20\r
+carl.d.worth@intel.com\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iD8DBQFMCEdX6JDdNq8qSWgRAnFmAJ9c/8QJJhK0TCg28QXFycXfO/3s1gCfcSn1\r
+qESwlVSHeNEXHAgO1yTKAlk=\r
+=/Co/\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r