Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l'

diff --git a/a1/e3fe9dab2a14522337f03465586a1b091e0e45 b/a1/e3fe9dab2a14522337f03465586a1b091e0e45
new file mode 100644 (file)
index 0000000..adc1112
--- /dev/null
+++ b/a1/e3fe9dab2a14522337f03465586a1b091e0e45
@@ -0,0 +1,121 @@
+Return-Path: <dme@dme.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id F34E06DE0231\r
+ for <notmuch@notmuchmail.org>; Tue,  9 Feb 2016 12:24:45 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.064\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.064 tagged_above=-999 required=5 tests=[AWL=0.003,\r
+  DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\r
+ RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_NEUTRAL=0.652,\r
+ UNPARSEABLE_RELAY=0.001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id uwXFuUlQF3jz for <notmuch@notmuchmail.org>;\r
+ Tue,  9 Feb 2016 12:24:43 -0800 (PST)\r
+Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com\r
+ [74.125.82.65]) by arlo.cworth.org (Postfix) with ESMTPS id 6D8CE6DE01D3 for\r
+ <notmuch@notmuchmail.org>; Tue,  9 Feb 2016 12:24:43 -0800 (PST)\r
+Received: by mail-wm0-f65.google.com with SMTP id p63so25219wmp.1\r
+ for <notmuch@notmuchmail.org>; Tue, 09 Feb 2016 12:24:43 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=dme-org.20150623.gappssmtp.com; s=20150623;\r
+ h=to:subject:in-reply-to:references:from:date:message-id:mime-version\r
+ :content-type; bh=H2xnsPje8F2GmbzqJ0v5WnPX3HPWWjDZXoOZdhzPsBA=;\r
+ b=nytkSuSHjOCMbmAtSYMIKPp5z9EDagvgKtx0uFoxUB1Of6tv8pu2mhITYZcNiAcnoC\r
+ IAJ4xyZVu+7hVgfgmt1lb0pOz0rOUPwdGdNHcWJSd/HWg5P8LDd3BQl4OFdRsO/VghTJ\r
+ wLMyEJnp1xhMu4XDgLaIFq/4stjO0381QPQDf/xiZ95cesx0r/QIPNbzwTbGG0Uq5UOn\r
+ Wr7PmvBQl+LzhmNaYocgFxwF7ZoysBsoeLisV3Z0rwplYogVylJxChRi3rBNm5++xoOk\r
+ cEU43YCJLeh2NtCsaQTAcGEyRB7BoNQur0xQewJkNpbBqLE3sPP9Sq874R7KnmhUPwYg\r
+ ZCIA==\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:to:subject:in-reply-to:references:from:date\r
+ :message-id:mime-version:content-type;\r
+ bh=H2xnsPje8F2GmbzqJ0v5WnPX3HPWWjDZXoOZdhzPsBA=;\r
+ b=OCrbzOFTfiAnJ+9OgQFMCG976sHsKf6wsh4XTu8qspHIROheBr73wlBWjDw0WiUHVR\r
+ Xs7n/CBypYu4pkw1ubyP0pnMPSQAcar5gSDI59myEpjMP42A1SXFER/D21PHZ8LV2vbZ\r
+ hvn7nyDoh6FHjF9lD3IJa/XWJxW9cl1tU5iUfBPTPfrOjxYJJLiex/zHWXn6/I5wFGyq\r
+ z9NQvwo84z44vC6FPxg7NorEXcl7HdiQIMwmu2/+bs8bHQOqM/ySv8CyfiNfAGjDoV0c\r
+ KgyjoyyQzEKaPD5SGqGcC4dh59GlqQJs4Zr43J74+PkDzpgOiWtUtyhuSrCrMRMAfhRn\r
+ 4VcA==\r
+X-Gm-Message-State:\r
+ AG10YOSPkQqgszglraxjOfM9r2/+X0oSpKk+Zhl5sjTq7oipHUZEsnEihyEMHH533hh+Qw==\r
+X-Received: by 10.28.180.84 with SMTP id d81mr7324807wmf.42.1455049481469;\r
+ Tue, 09 Feb 2016 12:24:41 -0800 (PST)\r
+Received: from disaster-area.hh.sledj.net\r
+ ([2a01:348:1a2:1:ea39:35ff:fe2c:a227])\r
+ by smtp.gmail.com with ESMTPSA id b1sm36305127wjy.0.2016.02.09.12.24.39\r
+ (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+ Tue, 09 Feb 2016 12:24:39 -0800 (PST)\r
+Received: from localhost (disaster-area.hh.sledj.net [local])\r
+ by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id e4f5946b;\r
+ Tue, 9 Feb 2016 20:24:38 +0000 (UTC)\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l'\r
+In-Reply-To: <1434182890-8047-4-git-send-email-markwalters1009@gmail.com>\r
+References: <1434182890-8047-1-git-send-email-markwalters1009@gmail.com>\r
+ <1434182890-8047-4-git-send-email-markwalters1009@gmail.com>\r
+From: David Edmondson <dme@dme.org>\r
+Date: Tue, 09 Feb 2016 20:24:38 +0000\r
+Message-ID: <m2io1x4oop.fsf@dme.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 09 Feb 2016 20:24:46 -0000\r
+\r
+On Sat, Jun 13 2015, Mark Walters wrote:\r
+> Change the key binding for filter (or "limit") in search-mode. This\r
+> gives consistency with the new filter in show-mode, and frees 'f' for\r
+> forward-thread in the future.\r
+\r
+Is there a conclusion on this change? The patch itself seems obviously\r
+fine from a code perspective, at issue is more whether it's acceptable\r
+to change the key binding.\r
+\r
+The equivalent binding in notmuch-show mode is already "l", and I think\r
+that it makes sense to be consistent (i.e. the change should be\r
+applied).\r
+\r
+> ---\r
+>  emacs/notmuch.el | 4 ++--\r
+>  1 file changed, 2 insertions(+), 2 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> index 6564816..06e3b94 100644\r
+> --- a/emacs/notmuch.el\r
+> +++ b/emacs/notmuch.el\r
+> @@ -166,7 +166,7 @@ (defvar notmuch-search-mode-map\r
+>      (define-key map "o" 'notmuch-search-toggle-order)\r
+>      (define-key map "c" 'notmuch-search-stash-map)\r
+>      (define-key map "t" 'notmuch-search-filter-by-tag)\r
+> -    (define-key map "f" 'notmuch-search-filter)\r
+> +    (define-key map "l" 'notmuch-search-filter)\r
+>      (define-key map [mouse-1] 'notmuch-search-show-thread)\r
+>      (define-key map "*" 'notmuch-search-tag-all)\r
+>      (define-key map "a" 'notmuch-search-archive-thread)\r
+> @@ -983,7 +983,7 @@ (defun notmuch-search-toggle-order ()\r
+>    (notmuch-search-refresh-view))\r
+>  \r
+>  (defun notmuch-search-filter (query)\r
+> -  "Filter the current search results based on an additional query string.\r
+> +  "Filter or LIMIT the current search results based on an additional query string.\r
+>  \r
+>  Runs a new search matching only messages that match both the\r
+>  current search results AND the additional query string provided."\r
+> -- \r
+> 2.1.4\r