Re: [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default

diff --git a/f4/39d8339df4b32f6dd5757cdbc787b9d1681040 b/f4/39d8339df4b32f6dd5757cdbc787b9d1681040
new file mode 100644 (file)
index 0000000..6ae92b5
--- /dev/null
+++ b/f4/39d8339df4b32f6dd5757cdbc787b9d1681040
@@ -0,0 +1,101 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 320D96DE1AE9\r
+ for <notmuch@notmuchmail.org>; Sun, 20 Sep 2015 05:28:41 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.158\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.158 tagged_above=-999 required=5 tests=[AWL=-0.238,\r
+  SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 25efpsF4vsHd for <notmuch@notmuchmail.org>;\r
+ Sun, 20 Sep 2015 05:28:39 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id D410E6DE1AE8\r
+ for <notmuch@notmuchmail.org>; Sun, 20 Sep 2015 05:28:38 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 1F80D10008D;\r
+ Sun, 20 Sep 2015 15:28:39 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default\r
+In-Reply-To: <87io75tji3.fsf@maritornes.cs.unb.ca>\r
+References: <1442004251-32325-1-git-send-email-tomi.ollila@iki.fi>\r
+ <87io75tji3.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 20 Sep 2015 15:28:38 +0300\r
+Message-ID: <m2lhc1b7gp.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 20 Sep 2015 12:28:41 -0000\r
+\r
+On Sun, Sep 20 2015, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>> make test V=1 (or any other value than 0) and make test V=0\r
+>> works similar way as build in general\r
+>> ---\r
+>>\r
+>> This is 2nd try: In first one I changed test-lib.sh -- there problem\r
+>> was the precedence between command line argument and NOTMUCH_TEST_QUIET\r
+>> environment variable. Here I don't see a problem there (although\r
+>> env NOTMUCH_TEST_QUIET=1 make test V=1 will make environment variable\r
+>> overrule the V=1 -- I am not sure who cares, though :D)\r
+>>\r
+>> Anyway, Someone(TM) may have better solution in mind, so let's\r
+>> get bikeshedding going!\r
+>>\r
+>\r
+> One thing I thought of was that we could replace the use of\r
+> NOTMUCH_TEST_QUIET with e.g. NOTMUCH_TEST_VERBOSE, and have that set by\r
+> the command line argument --verbose.  This would be less work on the\r
+> Makefile side, but I guess a bit more on the test-lib.sh side. I suppose\r
+> it might also be an annoyance for some people currently using\r
+> NOTMUCH_TEST_QUIET in some autobuilder setup. At the moment I can't\r
+> think of what would really break by changing this "API", but knows. The\r
+> current behaviour of having NOTMUCH_TEST_QUIET and --verbose completely\r
+> independent is pretty surprising.\r
+\r
+There was 2 primary motivations when I did that patch (which I forgot to\r
+mark rfc although I thought doing so) 1) that was the fastest at the time\r
+being and 2) the --verbose is already in use in test-lib.sh. \r
+\r
+First thing that come to my mind is that if (-v|--v[e[r[b[o[s[e]]]]]])\r
+option is for the suggested purpose its current behaviour is removed\r
+and when the option is not give user is informed how to activate "verbose"\r
+progress -- but as said that is just first thought...\r
+\r
+\r
+Making NOTMUCH_TEST_QUIET no-op is probably no annoyance to anyone...\r
+\r
+>\r
+> d\r
+>\r
+> P.S. I hope you appreciate my classic "scope-creep" technique in\r
+> bikeshedding. ;)\r
+\r
+In test-related issues that is fine by me.\r
+\r
+\r
+Tomi\r