Re: [PATCH 1/3] emacs: Fix mail composition under Emacs 23

diff --git a/96/f1ea8f72235a462add3f02e674282c8345220f b/96/f1ea8f72235a462add3f02e674282c8345220f
new file mode 100644 (file)
index 0000000..33dbd48
--- /dev/null
+++ b/96/f1ea8f72235a462add3f02e674282c8345220f
@@ -0,0 +1,68 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 183F66DE176C\r
+ for <notmuch@notmuchmail.org>; Mon,  4 Jan 2016 18:33:19 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.31\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.31 tagged_above=-999 required=5 tests=[AWL=0.241, \r
+ RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 02vDvfdC8VtQ for <notmuch@notmuchmail.org>;\r
+ Mon,  4 Jan 2016 18:33:16 -0800 (PST)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 978266DE176A\r
+ for <notmuch@notmuchmail.org>; Mon,  4 Jan 2016 18:33:16 -0800 (PST)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1aGHQl-0003GA-DP; Mon, 04 Jan 2016 21:33:03 -0500\r
+Received: (nullmailer pid 2722 invoked by uid 1000);\r
+ Tue, 05 Jan 2016 02:33:09 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/3] emacs: Fix mail composition under Emacs 23\r
+In-Reply-To: <1451753265-26713-2-git-send-email-sojkam1@fel.cvut.cz>\r
+References: <1451753265-26713-1-git-send-email-sojkam1@fel.cvut.cz>\r
+ <1451753265-26713-2-git-send-email-sojkam1@fel.cvut.cz>\r
+User-Agent: Notmuch/0.21+26~g9404723 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 04 Jan 2016 22:33:09 -0400\r
+Message-ID: <8760z8ah7e.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 05 Jan 2016 02:33:19 -0000\r
+\r
+Michal Sojka <sojkam1@fel.cvut.cz> writes:\r
+\r
+> +    (when return-action (nconc args '(return-action)))\r
+> +    (apply 'message-setup-1\r
+> +       ;; The following sexp is copied from `message-mail'\r
+\r
+> +       (nconc\r
+> +        `((To . ,(or to "")) (Subject . ,(or subject "")))\r
+\r
+I missed this the first time, but I a bit worried about this used of\r
+nconc. It seems to fall under "A common pitfall is to use a quoted\r
+constant list as a non-last argument to =E2=80=98nconc=E2=80=99"  (from the=\r
+ elisp\r
+manual).  In any case it's not really performance critical code (I\r
+guess?) so maybe we could just use append?\r
+\r
+The other use of nconc is more understandable to me.\r