Re: [RFC PATCH] emacs: Remove v command

diff --git a/3c/f057d9a9a5c6f24876cb30c81b89f2c5f8e15c b/3c/f057d9a9a5c6f24876cb30c81b89f2c5f8e15c
new file mode 100644 (file)
index 0000000..094b503
--- /dev/null
+++ b/3c/f057d9a9a5c6f24876cb30c81b89f2c5f8e15c
@@ -0,0 +1,114 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1989A431FAF\r
+       for <notmuch@notmuchmail.org>; Mon,  3 Jun 2013 09:28:45 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id XUBQLWqjImYZ for <notmuch@notmuchmail.org>;\r
+       Mon,  3 Jun 2013 09:28:37 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 48622431FAE\r
+       for <notmuch@notmuchmail.org>; Mon,  3 Jun 2013 09:28:37 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1UjXcP-0002fa-Vi; Mon, 03 Jun 2013 17:28:33 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1UjXcP-0000DZ-Ny; Mon, 03 Jun 2013 17:28:25 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [RFC PATCH] emacs: Remove v command\r
+In-Reply-To: <1370274895-32098-1-git-send-email-amdragon@mit.edu>\r
+References: <1370274895-32098-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1\r
+       (i486-pc-linux-gnu)\r
+Date: Mon, 03 Jun 2013 17:28:24 +0100\r
+Message-ID: <87ehcjf9av.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: e107f8a2901f6efc6247be86f0d4443a (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -0.0 points.\r
+       Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 03 Jun 2013 16:28:45 -0000\r
+\r
+\r
+I like the change. +1 from me.\r
+\r
+Mark\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> This removes the v command, since we now have much nicer part commands,\r
+> and deprecates the underlying notmuch-show-view-all-mime-parts.  This\r
+> also means that people who try using the old unprefixed 'v' command on\r
+> a part button will no longer be greeted by ALL of their parts popping\r
+> up.\r
+> ---\r
+>  emacs/notmuch-show.el |    4 +++-\r
+>  1 file changed, 3 insertions(+), 1 deletion(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 5771950..bae3171 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -213,6 +213,9 @@ For example, if you wanted to remove an \"unread\" tag and add a\r
+>    "Enable Visual Line mode."\r
+>    (visual-line-mode t))\r
+>  \r
+> +;; DEPRECATED in Notmuch 0.16 since we now have convenient part\r
+> +;; commands.  We'll keep the command around for a version or two in\r
+> +;; case people want to bind it themselves.\r
+>  (defun notmuch-show-view-all-mime-parts ()\r
+>    "Use external viewers to view all attachments from the current message."\r
+>    (interactive)\r
+> @@ -1216,7 +1219,6 @@ reset based on the original query."\r
+>      (define-key map "|" 'notmuch-show-pipe-message)\r
+>      (define-key map "w" 'notmuch-show-save-attachments)\r
+>      (define-key map "V" 'notmuch-show-view-raw-message)\r
+> -    (define-key map "v" 'notmuch-show-view-all-mime-parts)\r
+>      (define-key map "c" 'notmuch-show-stash-map)\r
+>      (define-key map "=" 'notmuch-show-refresh-view)\r
+>      (define-key map "h" 'notmuch-show-toggle-visibility-headers)\r
+> -- \r
+> 1.7.10.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r