Re: [PATCH 0/6] Clean up reply's encoding story

diff --git a/0e/488ed40b67318682bfc9d2b06b1a59aee37faf b/0e/488ed40b67318682bfc9d2b06b1a59aee37faf
new file mode 100644 (file)
index 0000000..ebb28bc
--- /dev/null
+++ b/0e/488ed40b67318682bfc9d2b06b1a59aee37faf
@@ -0,0 +1,112 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 26DF8431FD4\r
+       for <notmuch@notmuchmail.org>; Wed, 14 Aug 2013 10:20:48 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Y0IfAealPF6L for <notmuch@notmuchmail.org>;\r
+       Wed, 14 Aug 2013 10:20:42 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-3.mit.edu (dmz-mailsec-scanner-3.mit.edu\r
+       [18.9.25.14])\r
+       by olra.theworths.org (Postfix) with ESMTP id 94E98431FC0\r
+       for <notmuch@notmuchmail.org>; Wed, 14 Aug 2013 10:20:42 -0700 (PDT)\r
+X-AuditID: 1209190e-b7f988e0000009a7-1e-520bbc696eab\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id FA.EE.02471.96CBB025; Wed, 14 Aug 2013 13:20:41 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id r7EHKdEJ003180; \r
+       Wed, 14 Aug 2013 13:20:40 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r7EHKb03012335\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+       Wed, 14 Aug 2013 13:20:38 -0400\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1V9ekO-0005PA-Vz; Wed, 14 Aug 2013 13:20:37 -0400\r
+Date: Wed, 14 Aug 2013 13:20:36 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH 0/6] Clean up reply's encoding story\r
+Message-ID: <20130814172036.GF13257@mit.edu>\r
+References: <1376332839-22825-1-git-send-email-amdragon@mit.edu>\r
+       <m2zjskjjat.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <m2zjskjjat.fsf@guru.guru-group.fi>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hRV1s3cwx1kMGOTsMX1mzOZLd6snMfq\r
+       wORx+OtCFo9nq24xBzBFcdmkpOZklqUW6dslcGX82WJY8JKvYkbDL8YGxvfcXYycHBICJhLN\r
+       dw6wQthiEhfurWfrYuTiEBLYxyhxs/02K4SzkVHi8pZXzBDOaSaJuy2nwFqEBJYwSqxoVAGx\r
+       WQRUJRpWvWUHsdkENCS27V/OCGKLCKhIPGhbD1bPLCAt8e13MxOILSxgIdF54gJYnFdAR2LV\r
+       p28sEDPTJD4f7WKHiAtKnJz5hAWiV0vixr+XQL0cYHOW/+MACXMKGEgcv7eTGcQWBVo15eQ2\r
+       tgmMQrOQdM9C0j0LoXsBI/MqRtmU3Crd3MTMnOLUZN3i5MS8vNQiXWO93MwSvdSU0k2M4KCW\r
+       5NvB+PWg0iFGAQ5GJR7eiDbuICHWxLLiytxDjJIcTEqivP7bgUJ8SfkplRmJxRnxRaU5qcWH\r
+       GCU4mJVEeM90AOV4UxIrq1KL8mFS0hwsSuK8z56eDRQSSE8sSc1OTS1ILYLJynBwKEnwhu4G\r
+       ahQsSk1PrUjLzClBSDNxcIIM5wEavmoXyPDigsTc4sx0iPwpRkUpcV41kGYBkERGaR5cLyzp\r
+       vGIUB3pFmDcJpIoHmLDgul8BDWYCGuyQzQUyuCQRISXVwNgy+9M2kUp5h2sqcWz8r83Xb7Rj\r
+       Um79NOfkx0hOq27NoiXmZ54efKBba/z7u0vereScaxfPXVWYqq0aPiGr58T/nJNumUoyL8ya\r
+       bwnHH/r0M+PLg60/77gx+E2VLtodYSKrFu33O2feeua9spnZXwvXXhRfb3P7zlXnB8F2klVq\r
+       kq7KC2q1XiuxFGckGmoxFxUnAgB7JuoqFQMAAA==\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 14 Aug 2013 17:20:48 -0000\r
+\r
+Quoth Tomi Ollila on Aug 14 at  8:04 pm:\r
+> On Mon, Aug 12 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> \r
+> > Jeff Stedfast's email about gmime-filter-headers.c possibly being\r
+> > unnecessary with GMime 2.6 (quoted in id:87bo56viyo.fsf@nikula.org)\r
+> > sent me on a wild goose chase that led to this patch series.  It\r
+> > turned out that we *did* need gmime-filter-headers for what we were\r
+> > doing in the reply text format, but what we were doing made no sense.\r
+> > Patches 1 through 4 are simply the documentation and tests that I left\r
+> > in my wake and are harmless to push.  Patch 6 is my conclusion that\r
+> > how we were handling header encoding in the text reply format made no\r
+> > sense.  Patch 5 is a step toward patch 6, but makes sense on its own\r
+> > even if we decide against patch 6.\r
+> \r
+> The whole series Looks Good To Me (sans known hiccups). I tested the patch 6\r
+> affecting 'default' output of notmuch reply bot not json or sexp output\r
+> (which I found surprising as so much code was removed). All the explations\r
+> in id:1376332839-22825-7-git-send-email-amdragon@mit.edu makes good sense\r
+> (but fix also 'tmeplate').\r
+> \r
+> A slighly related note: ^M:s ^J:s (among other chars) don't get encoded\r
+> into =?utf-8?b?...?= ...\r
+\r
+Do you mean when sending mail, or when replying to a message with\r
+encoded ^Ms and ^Js?\r
+\r
+> ... also interestingly if U+202E (LEFT-TO-RIGHT OVERRIDE) is in (at least\r
+> From) header it disappears from `notmuch reply` default format. In json\r
+> and sexp format it disappears in 'reply-headers' but exists in 'headers'.\r
+> emacs client seems to use reply-headers as none of the header text lines\r
+> in buffer is  rendered RTL.\r
+\r
+Cool.  My guess would be that one of these it coming from notmuch's\r
+internal header parser (via notmuch_message_get_header) and the other\r
+is coming from GMime's header parser (used in notmuch-show.c)\r