Re: [PATCH] python/thread: always return a string in get_subject/authors

diff --git a/aa/4965b6f7b408d62e109e444e11d254a9af5f37 b/aa/4965b6f7b408d62e109e444e11d254a9af5f37
new file mode 100644 (file)
index 0000000..868939b
--- /dev/null
+++ b/aa/4965b6f7b408d62e109e444e11d254a9af5f37
@@ -0,0 +1,118 @@
+Return-Path: <Sebastian@SSpaeth.de>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id EB1D0429E27\r
+       for <notmuch@notmuchmail.org>; Mon,  9 May 2011 18:00:51 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.09\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.09 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       RCVD_IN_DNSWL_NONE=-0.0001, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id AUft7FgMEM5f for <notmuch@notmuchmail.org>;\r
+       Mon,  9 May 2011 18:00:51 -0700 (PDT)\r
+Received: from homiemail-a76.g.dreamhost.com (mailbigip.dreamhost.com\r
+       [208.97.132.5])\r
+       by olra.theworths.org (Postfix) with ESMTP id 40215429E26\r
+       for <notmuch@notmuchmail.org>; Mon,  9 May 2011 18:00:51 -0700 (PDT)\r
+Received: from homiemail-a76.g.dreamhost.com (localhost [127.0.0.1])\r
+       by homiemail-a76.g.dreamhost.com (Postfix) with ESMTP id 7AE51458080;\r
+       Mon,  9 May 2011 18:00:50 -0700 (PDT)\r
+DomainKey-Signature: a=rsa-sha1; c=nofws; d=SSpaeth.de; h=from:to:subject\r
+       :in-reply-to:references:date:message-id:mime-version:\r
+       content-type; q=dns; s=sspaeth.de; b=azxpWIOOqew6ig0ZRQcbHq2ibkT\r
+       nkPPSjNGf9ReSwuPEvJNMbQAp9s9qVNpjX9sFMwCDR14vorXl84pczQOKEqPhPTH\r
+       g+tTDyGRkA7Y8nLlK2tRUpkU6SALofqYuEnFXMf/2LzVpxEsndDvi3FgdysHhj9I\r
+       Qd9ln6hP2de6fvIs=\r
+DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=SSpaeth.de; h=from:to\r
+       :subject:in-reply-to:references:date:message-id:mime-version:\r
+       content-type; s=sspaeth.de; bh=vPqNp0k2gybtKmIdECYhaCMbNOI=; b=N\r
+       Zr4/PZ+lXJwL89BQUKhPGdQ3eKIegVDPNQ93sPO7rSq46OYWnBF9x2UuxtG8sBal\r
+       45ftx3ZXB2drh+wcu2Qb5dyg8wUyNBkJSrR49LIlEXK9MQZJz2fgDCstbgXE6ydk\r
+       pgUwPSqeN+XJnpOYRBNqpVAcot8rATTFGuT4SeYGN8=\r
+Received: from spaetzbook.sspaeth.de (c80-217-195-47.bredband.comhem.se\r
+       [80.217.195.47])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       (Authenticated sender: fax@sspaeth.de)\r
+       by homiemail-a76.g.dreamhost.com (Postfix) with ESMTPSA id AE269458079; \r
+       Mon,  9 May 2011 18:00:48 -0700 (PDT)\r
+Received: by spaetzbook.sspaeth.de (sSMTP sendmail emulation);\r
+       Tue, 10 May 2011 03:00:45 +0200\r
+From: Sebastian Spaeth <Sebastian@SSpaeth.de>\r
+To: David Bremner <david@tethera.net>, Anton Khirnov <anton@khirnov.net>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] python/thread: always return a string in\r
+       get_subject/authors\r
+In-Reply-To: <87bozcvzdy.fsf@zancas.localnet>\r
+References: <1304924794-20380-1-git-send-email-anton@khirnov.net>\r
+       <87bozcvzdy.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.5-164-g8ce82ed (http://notmuchmail.org) Emacs/23.1.50.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 10 May 2011 03:00:44 +0200\r
+Message-ID: <87zkmv5pz6.fsf@SSpaeth.de>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 10 May 2011 01:00:52 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Mon, 09 May 2011 09:20:41 -0300, David Bremner <david@tethera.net> wrote:\r
+> On Mon,  9 May 2011 09:06:34 +0200, Anton Khirnov <anton@khirnov.net> wro=\r
+te:\r
+> > Now None is returned when those don't exist, which is inconvenient to\r
+> > deal with.\r
+>=20\r
+> I'm not using the python bindings, but from a philosophical point of\r
+> view, this change makes me a bit uncomfortable since it apparently\r
+> merges two cases together, and makes an error (no Subject)\r
+> indistinguishable from an odd situation (Subject of empty string).\r
+> Or am I missing something here?\r
+\r
+Hi there,\r
+\r
+This change makes me a bit uncomfortable too. 3 Reasons:\r
+\r
+=2D I believe users should be able to distinguish the case when someone\r
+  uses an empty subject, and when someone doesn't specify a subject at\r
+  all.\r
+\r
+=2D People have been writing code and breaking backwards compatability for\r
+  such a small gain doesn't really seem worth it.\r
+\r
+=2D Testing-wise this is easy. Just test for "if subject:" on the returned\r
+  value and you'll get both cases (empty and non-existing).\r
+\r
+But if people really want it, I won't object.\r
+\r
+Sebastian\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk3Ijj0ACgkQVYX1jMgnoGK9KACfWcOpLx/BBx6ag1dkf7KGN5yX\r
+PyAAn0kBkL6eqFKegSJprr7HE+GiSLeW\r
+=+jUo\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r