Re: [PATCH 3/6] lib: use the backup path provided by the user, don't add anything...

diff --git a/63/da9bc242fc6c9b2509b8d040f1b18b2cb693d7 b/63/da9bc242fc6c9b2509b8d040f1b18b2cb693d7
new file mode 100644 (file)
index 0000000..8d4bb4d
--- /dev/null
+++ b/63/da9bc242fc6c9b2509b8d040f1b18b2cb693d7
@@ -0,0 +1,124 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1ED46431FAF\r
+       for <notmuch@notmuchmail.org>; Sat,  2 Nov 2013 05:22:44 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.699\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5\r
+       tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 4YVqohe36h2X for <notmuch@notmuchmail.org>;\r
+       Sat,  2 Nov 2013 05:22:38 -0700 (PDT)\r
+Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com\r
+       [209.85.220.171]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 1BB97431FAE\r
+       for <notmuch@notmuchmail.org>; Sat,  2 Nov 2013 05:22:38 -0700 (PDT)\r
+Received: by mail-vc0-f171.google.com with SMTP id ik5so3539212vcb.2\r
+       for <notmuch@notmuchmail.org>; Sat, 02 Nov 2013 05:22:37 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=1e100.net; s=20130820;\r
+       h=x-gm-message-state:mime-version:in-reply-to:references:date\r
+       :message-id:subject:from:to:cc:content-type;\r
+       bh=3UBUPW6wljv4Bq7vO9nGqRLIC99DXjnPmK/yaXc9P0A=;\r
+       b=SUlutS/lQeVA7cjG8Ox72g0FW2dCV7Dw0KaW1IDTPVgB81T8vhv5Y+H2iqx8mutVN9\r
+       douHfzqr/VUvy/eqRRRuACdoeX3pHiPJJ+IXZ497ZNOXbuquYY3PY+C/cCrN4F+FI6Dq\r
+       ZgUICp3BwJNVqlEe8Qe2iTzNExkZes93y9mQYVur5x4LxBk0XYvD3wnlM8mV5v/jrmtI\r
+       YM1vkG9FNtdEdfY2dkO+R8tWooIqgKxLmn6R/XTkZ6pSJoi73I27P/YwmGXnRbXbC2Zy\r
+       4Xs+3hvfDw4rvO5pmdZtru3ISmdWX6+TwGlGq9slQax1fpIQlKOP+OJPBPf8g+T3Nnij\r
+       GhaQ==\r
+X-Gm-Message-State:\r
+ ALoCoQlkidzT3HgKZzHDFKK7P1Cj6PId6NWz7JanUwfi0Tgw+7j76pmuMuHaD0xd89HhbOMdsu2D\r
+MIME-Version: 1.0\r
+X-Received: by 10.220.182.69 with SMTP id cb5mr283487vcb.41.1383394957503;\r
+       Sat, 02 Nov 2013 05:22:37 -0700 (PDT)\r
+Received: by 10.58.96.20 with HTTP; Sat, 2 Nov 2013 05:22:37 -0700 (PDT)\r
+Received: by 10.58.96.20 with HTTP; Sat, 2 Nov 2013 05:22:37 -0700 (PDT)\r
+In-Reply-To: <87li17rof6.fsf@zancas.localnet>\r
+References: <cover.1383315568.git.jani@nikula.org>\r
+       <9ee3f2334a117b0a1b88650f44432423cbe95fd7.1383315568.git.jani@nikula.org>\r
+       <87li17rof6.fsf@zancas.localnet>\r
+Date: Sat, 2 Nov 2013 14:22:37 +0200\r
+Message-ID:\r
+ <CAB+hUn_QUzdEJrc3VUd2WHV2CKjFu+iq6C1zP3dPN6D1T+aq2A@mail.gmail.com>\r
+Subject: Re: [PATCH 3/6] lib: use the backup path provided by the user, don't\r
+       add anything to it\r
+From: Jani Nikula <jani@nikula.org>\r
+To: David Bremner <david@tethera.net>\r
+Content-Type: multipart/alternative; boundary=001a1132e2c2071dbb04ea30bd30\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 02 Nov 2013 12:22:44 -0000\r
+\r
+--001a1132e2c2071dbb04ea30bd30\r
+Content-Type: text/plain; charset=UTF-8\r
+\r
+On Nov 2, 2013 2:14 PM, "David Bremner" <david@tethera.net> wrote:\r
+>\r
+> Jani Nikula <jani@nikula.org> writes:\r
+>\r
+> > Adding another level is just useless cruft.\r
+> > ---\r
+> >  lib/database.cc   |   14 ++++----------\r
+> >  notmuch-compact.c |    4 ++--\r
+> >  2 files changed, 6 insertions(+), 12 deletions(-)\r
+>\r
+> The first two patches are fine, modulo my comments about documentation.\r
+> I think the backup path needs to be updated in notmuch-compact.c, and\r
+> possible the test updated (after applying\r
+> id:1383350515-24320-1-git-send-email-david@tethera.net)\r
+>\r
+> d\r
+\r
+Ah, right, I was juggling the patch order back and forth a bit, and I\r
+missed this (as I drop the path completely in a later patch).\r
+\r
+Jani.\r
+\r
+--001a1132e2c2071dbb04ea30bd30\r
+Content-Type: text/html; charset=UTF-8\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+<p dir=3D"ltr"><br>\r
+On Nov 2, 2013 2:14 PM, &quot;David Bremner&quot; &lt;<a href=3D"mailto:dav=\r
+id@tethera.net">david@tethera.net</a>&gt; wrote:<br>\r
+&gt;<br>\r
+&gt; Jani Nikula &lt;<a href=3D"mailto:jani@nikula.org">jani@nikula.org</a>=\r
+&gt; writes:<br>\r
+&gt;<br>\r
+&gt; &gt; Adding another level is just useless cruft.<br>\r
+&gt; &gt; ---<br>\r
+&gt; &gt; =C2=A0lib/database.cc =C2=A0 | =C2=A0 14 ++++----------<br>\r
+&gt; &gt; =C2=A0notmuch-compact.c | =C2=A0 =C2=A04 ++--<br>\r
+&gt; &gt; =C2=A02 files changed, 6 insertions(+), 12 deletions(-)<br>\r
+&gt;<br>\r
+&gt; The first two patches are fine, modulo my comments about documentation=\r
+.<br>\r
+&gt; I think the backup path needs to be updated in notmuch-compact.c, and<=\r
+br>\r
+&gt; possible the test updated (after applying<br>\r
+&gt; <a href=3D"mailto:id%3A1383350515-24320-1-git-send-email-david@tethera=\r
+.net">id:1383350515-24320-1-git-send-email-david@tethera.net</a>)<br>\r
+&gt;<br>\r
+&gt; d</p>\r
+<p dir=3D"ltr">Ah, right, I was juggling the patch order back and forth a b=\r
+it, and I missed this (as I drop the path completely in a later patch).</p>\r
+<p dir=3D"ltr">Jani.<br></p>\r
+\r
+--001a1132e2c2071dbb04ea30bd30--\r