Re: [PATCH v2] test: exit with nonzero value when not all tests completed successfully

diff --git a/3a/d33a717cd5dc1ef2c82dc174e1c247313bbdb2 b/3a/d33a717cd5dc1ef2c82dc174e1c247313bbdb2
new file mode 100644 (file)
index 0000000..5535fe1
--- /dev/null
+++ b/3a/d33a717cd5dc1ef2c82dc174e1c247313bbdb2
@@ -0,0 +1,137 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4CEDD431FB6\r
+       for <notmuch@notmuchmail.org>; Sun,  8 Sep 2013 10:38:42 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id gZvDs8sE1tVM for <notmuch@notmuchmail.org>;\r
+       Sun,  8 Sep 2013 10:38:34 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id F292F431FAE\r
+       for <notmuch@notmuchmail.org>; Sun,  8 Sep 2013 10:38:33 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1VIiwH-0006FF-Un; Sun, 08 Sep 2013 18:38:24 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1VIiwH-0005AM-KM; Sun, 08 Sep 2013 18:38:21 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] test: exit with nonzero value when not all tests\r
+       completed successfully\r
+In-Reply-To: <1378655610-21497-1-git-send-email-tomi.ollila@iki.fi>\r
+References: <1378655610-21497-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 08 Sep 2013 18:38:20 +0100\r
+Message-ID: <8738pf8b8z.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 376fdc25dea9a4a20d214dc8c001e771 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored 0.0 points. Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       *  0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 08 Sep 2013 17:38:42 -0000\r
+\r
+\r
+LGTM +1\r
+\r
+Mark\r
+\r
+On Sun, 08 Sep 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> If any of the tests in our test system is not passing the execution\r
+> of the test suite completes with nonzero exit value.\r
+>\r
+> It is better to rely on the exit value of the test system instead\r
+> of some arbitrary strings in test output (or use both).\r
+> ---\r
+>\r
+> This is v2 of id:1378479935-26312-1-git-send-email-tomi.ollila@iki.fi\r
+> thanks to Mark's observation in id:87d2olg9bz.fsf@qmul.ac.uk\r
+> which widened my thought region :D\r
+>\r
+> Tomi\r
+>\r
+>  test/aggregate-results.sh | 9 +++++++++\r
+>  test/notmuch-test         | 3 +++\r
+>  2 files changed, 12 insertions(+)\r
+>\r
+> diff --git a/test/aggregate-results.sh b/test/aggregate-results.sh\r
+> index 732d6ca..b016edb 100755\r
+> --- a/test/aggregate-results.sh\r
+> +++ b/test/aggregate-results.sh\r
+> @@ -1,5 +1,7 @@\r
+>  #!/usr/bin/env bash\r
+>  \r
+> +set -eu\r
+> +\r
+>  fixed=0\r
+>  success=0\r
+>  failed=0\r
+> @@ -79,3 +81,10 @@ if [ "$skipped" != "0" ]; then\r
+>      tests=$(pluralize "test" $skipped)\r
+>      echo "$skipped $tests skipped."\r
+>  fi\r
+> +\r
+> +if [ $success -gt 0 -a $fixed -eq 0 -a $failed -eq 0 -a $skipped -eq 0 ]\r
+> +then\r
+> +    exit 0\r
+> +else\r
+> +    exit 1\r
+> +fi\r
+> diff --git a/test/notmuch-test b/test/notmuch-test\r
+> index 6db7979..aa28bb0 100755\r
+> --- a/test/notmuch-test\r
+> +++ b/test/notmuch-test\r
+> @@ -97,6 +97,9 @@ trap - HUP INT TERM\r
+>  \r
+>  # Report results\r
+>  ./aggregate-results.sh test-results/*\r
+> +ev=$?\r
+>  \r
+>  # Clean up\r
+>  rm -rf test-results corpus.mail\r
+> +\r
+> +exit $ev\r
+> -- \r
+> 1.8.0\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r