--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 78BCE429E41\r
+ for <notmuch@notmuchmail.org>; Tue, 4 Nov 2014 01:15:25 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id UEusnN6X7nqL for <notmuch@notmuchmail.org>;\r
+ Tue, 4 Nov 2014 01:15:21 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id A4864429E40\r
+ for <notmuch@notmuchmail.org>; Tue, 4 Nov 2014 01:15:21 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1XlaCZ-0007k8-Bj; Tue, 04 Nov 2014 09:15:19 +0000\r
+Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1XlaCZ-0005JQ-0X; Tue, 04 Nov 2014 09:14:59 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>, Michal Sojka <sojkam1@fel.cvut.cz>\r
+Subject: Re: [RFC PATCH 0/2] cli: split 'notmuch address' from 'notmuch\r
+ search'\r
+In-Reply-To: <cover.1414839970.git.jani@nikula.org>\r
+References: <87egtn2s4z.fsf@steelpick.2x.cz>\r
+ <cover.1414839970.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 04 Nov 2014 09:14:58 +0000\r
+Message-ID: <87r3xj2up9.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 87.81.223.162\r
+X-QM-Geographic: According to ripencc,\r
+ this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: e99114c32f0de8f8d0c575c1d5234595 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.1\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -0.1 points.\r
+ Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.1 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 04 Nov 2014 09:15:25 -0000\r
+\r
+\r
+On Sat, 01 Nov 2014, Jani Nikula <jani@nikula.org> wrote:\r
+> On Sat, 01 Nov 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+>> On Sat, Nov 01 2014, Jani Nikula wrote:\r
+>>> On Fri, 31 Oct 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+>>>> This option allows to configure the criterion for duplicate address\r
+>>>> filtering. Without this option, all unique combinations of name and\r
+>>>> address parts are printed. This option allows to filter the output\r
+>>>> more, for example to only contain unique address parts.\r
+>>>\r
+>>> This patch finally makes me think we should have a separate 'notmuch\r
+>>> address' command for all of this. We are starting to have two orthogonal\r
+>>> sets of 'notmuch search' options, one set for search and another for\r
+>>> addresses. I regret not following the series and then making the\r
+>>> observation so late.\r
+>>\r
+>> To some extent it is true. The question is whether it would make sense\r
+>> for 'notmuch address' to have options like --offset and --limit.\r
+>> Probably not.\r
+>>\r
+>> I can prepare a new patchset implementing 'notmuch address' over the\r
+>> weekend. It would be necessary to revert the last (or two) already\r
+>> merged patch. What do others think?\r
+>\r
+> Here's a couple of draft patches to make the search/address command\r
+> split happen with minimal changes.\r
+>\r
+> In my opinion the problem is primarily in the user interface;\r
+> notmuch-search man page is growing intimidating to the user. I also\r
+> think splitting the implementation completely would lead to too much\r
+> code duplication, as there is plenty of common code. The idea here is to\r
+> split the user interface for address searching now when we haven't made\r
+> a release with the functionality, and we can more easily change the code\r
+> behind the interface going forward. Plus we can more comfortably add\r
+> address management commands to 'notmuch address' than 'notmuch search'\r
+> as the need arises.\r
+>\r
+> I do have to say in the end I'm also fine with having everything in the\r
+> notmuch search command if there's opposition to having two very similar,\r
+> even if diverging, commands.\r
+\r
+I like this change and have reviewed the large follow-up series. Would\r
+this make it easy to support the generic notmuch options after the\r
+command? In particular I often type/think notmuch search --help rather than\r
+notmuch --help search.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+\r
+\r
+>\r
+> BR,\r
+> Jani.\r
+>\r
+>\r
+> Jani Nikula (2):\r
+> cli: add support for hierarchical command line option arrays\r
+> cli: add notmuch address command\r
+>\r
+> command-line-arguments.c | 11 ++--\r
+> command-line-arguments.h | 1 +\r
+> notmuch-client.h | 3 ++\r
+> notmuch-search.c | 128 ++++++++++++++++++++++++++++++-----------------\r
+> notmuch.c | 2 +\r
+> 5 files changed, 95 insertions(+), 50 deletions(-)\r
+>\r
+> -- \r
+> 2.1.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff