Re: [PATCH] notmuch-dump: use fsync instead of fdatasync

diff --git a/cc/bdbfdf5c10c39b860a8d93efa4674fb6a68ed1 b/cc/bdbfdf5c10c39b860a8d93efa4674fb6a68ed1
new file mode 100644 (file)
index 0000000..192eb08
--- /dev/null
+++ b/cc/bdbfdf5c10c39b860a8d93efa4674fb6a68ed1
@@ -0,0 +1,81 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D4AE2431FBF\r
+       for <notmuch@notmuchmail.org>; Thu,  8 May 2014 08:36:40 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id FeaAFMbtrAkZ for <notmuch@notmuchmail.org>;\r
+       Thu,  8 May 2014 08:36:36 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8E528431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  8 May 2014 08:36:36 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 1683F1000E5;\r
+       Thu,  8 May 2014 18:36:29 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] notmuch-dump: use fsync instead of fdatasync\r
+In-Reply-To: <1399550227-18488-1-git-send-email-david@tethera.net>\r
+References: <20140507171835.GA27619@mit.edu>\r
+       <1399550227-18488-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.18+11~gbc95cc5 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 08 May 2014 18:36:28 +0300\r
+Message-ID: <m2r444wadf.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 08 May 2014 15:36:41 -0000\r
+\r
+On Thu, May 08 2014, David Bremner <david@tethera.net> wrote:\r
+\r
+> Since the file size will have changed, there is no performance benefit\r
+> to calling fdatasync.  Somewhat surprisingly, using fdatasync\r
+> apparently causes portability problems on FreeBSD.\r
+> ---\r
+\r
+Well, this is easy to review! LGTM.\r
+\r
+Tomi\r
+\r
+\r
+>  notmuch-dump.c | 2 +-\r
+>  1 file changed, 1 insertion(+), 1 deletion(-)\r
+>\r
+> diff --git a/notmuch-dump.c b/notmuch-dump.c\r
+> index 2849eab..887a208 100644\r
+> --- a/notmuch-dump.c\r
+> +++ b/notmuch-dump.c\r
+> @@ -169,7 +169,7 @@ notmuch_database_dump (notmuch_database_t *notmuch,\r
+>      }\r
+>  \r
+>      if (output_file_name) {\r
+> -    ret = fdatasync (outfd);\r
+> +    ret = fsync (outfd);\r
+>      if (ret) {\r
+>          fprintf (stderr, "Error syncing %s to disk: %s\n",\r
+>                   name_for_error, strerror (errno));\r
+> -- \r
+> 1.9.2\r