Re: Python bindings and Xapian exceptions

diff --git a/f2/ec057f9a2b48899ddaa5c024040bf7b88846c6 b/f2/ec057f9a2b48899ddaa5c024040bf7b88846c6
new file mode 100644 (file)
index 0000000..6db105f
--- /dev/null
+++ b/f2/ec057f9a2b48899ddaa5c024040bf7b88846c6
@@ -0,0 +1,103 @@
+Return-Path: <mattator@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 657F7431FC4\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Dec 2014 12:46:44 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ZkRZArj35Ct9 for <notmuch@notmuchmail.org>;\r
+       Mon, 15 Dec 2014 12:46:41 -0800 (PST)\r
+Received: from mail-qa0-f48.google.com (mail-qa0-f48.google.com\r
+       [209.85.216.48]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 1EBA6431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Dec 2014 12:46:41 -0800 (PST)\r
+Received: by mail-qa0-f48.google.com with SMTP id v10so8648580qac.21\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Dec 2014 12:46:40 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=mime-version:in-reply-to:references:date:message-id:subject:from:to\r
+       :cc:content-type;\r
+       bh=A/zw5n3vMoZnapi8hlyv4MGR+qU2RaT6ivCEzu3LO30=;\r
+       b=jXCH5Qgcjy+Gp+f5hvJ5Ar+6rwF8bCgihjAMWgU1TtGvyA7c5hs6GY0UlF59PRR785\r
+       otvLajJ6AmrmPinTihHXH7isws0jiJ47TCSaLWDQyIX0gKEjKq1zgqPzIG5v3yAQd28R\r
+       b44A3GI67AhQBq4tOhBg0w41O11PwaTs0qUKapwnQG4MOyZqc/YFPKsBL9Kx4JBF5dVs\r
+       CH3o9ROfS32/DeeStK3qUwbtye6xqIdiIIhteCAqKz+kODhy3tit8GkyoJy3LPQ//aDD\r
+       C4iw7eoC//VCV020M41xDdTdnXlT2FWV70dmXSATiCcxvMEalbl08i0oxsejKKx7ctmq\r
+       Y/OQ==\r
+MIME-Version: 1.0\r
+X-Received: by 10.140.85.104 with SMTP id m95mr55358337qgd.93.1418676400496;\r
+       Mon, 15 Dec 2014 12:46:40 -0800 (PST)\r
+Received: by 10.96.77.105 with HTTP; Mon, 15 Dec 2014 12:46:40 -0800 (PST)\r
+In-Reply-To: <87iohc7iiz.fsf@maritornes.cs.unb.ca>\r
+References: <87k4q7s43v.fsf@ut.hh.sledj.net> <878w6gis5g.fsf@SSpaeth.de>\r
+       <871v70ril7.fsf@yoom.home.cworth.org> <871v70z0y5.fsf@SSpaeth.de>\r
+       <loom.20141215T121709-488@post.gmane.org>\r
+       <87iohc7iiz.fsf@maritornes.cs.unb.ca>\r
+Date: Mon, 15 Dec 2014 21:46:40 +0100\r
+Message-ID:\r
+ <CADHp1NyiuG-V2b68fsie_Fhn0kigUM88bPinhE9yZPCsWNW6QA@mail.gmail.com>\r
+Subject: Re: Python bindings and Xapian exceptions\r
+From: Matt <mattator@gmail.com>\r
+To: David Bremner <david@tethera.net>\r
+Content-Type: text/plain; charset=UTF-8\r
+X-Mailman-Approved-At: Tue, 16 Dec 2014 00:13:44 -0800\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 15 Dec 2014 20:46:44 -0000\r
+\r
+2014-12-15 21:41 GMT+01:00 David Bremner <david@tethera.net>:\r
+> Matt <mattator@gmail.com> writes:\r
+>\r
+>>> > But for exceptions in general, yes the notmuch library does need to be\r
+>>> > fixed to allow the caller of functions to distinguish between things\r
+>>> > like "no matches found" and "an exception occurred, so it's unknown if\r
+>>> > any messages match the search". That's a general class of library\r
+>>> > interface bugs that all need to be fixed.\r
+>>\r
+>> I 've also hit this *API bug* and was wondering if a fix had been done since\r
+>> then (I use notmuch 0.17) ? I found nothing on http://notmuchmail.org/news/\r
+>\r
+> Can you be more specific? I'd say in general no thorough overhaul of\r
+> error handling has happened, but if you can tell us what particular\r
+> libnotmuch function (or the equivalient python binding) you are having\r
+> trouble with, we may be able to give a more informative answer.\r
+>\r
+\r
+For instance when using the python bindings:\r
+In constructor I do\r
+self.db = notmuch.Database(self.db_path)\r
+and there I have a method called periodically that returns:\r
+returns notmuch.Query(self.db, "tag:unread and tag:inbox").count_messages()\r
+\r
+When it fails the previous method returns 0 and displays on stdout/stderr;\r
+"A Xapian exception occurred: The revision being read has been\r
+discarded - you should call Xapian::Database::reopen() and retry the\r
+operation\r
+Query string was: tag:unread and tag:inbox"\r
+\r
+The way for me to detect an error is to redirect stdout and check if\r
+the method outputted to stdout, which is not practical. I wish it\r
+would either return "-1", throw an exception or return 2 numbers like\r
+"errorcode, returned value". I personnally don't care if it's done at\r
+the library level or in the python bindings.\r
+\r
+Regards\r