Re: [PATCH] emacs: update search sort order help to match code

diff --git a/4d/cc231d473e27e8502fb8c253cd59e34207e072 b/4d/cc231d473e27e8502fb8c253cd59e34207e072
new file mode 100644 (file)
index 0000000..5ee5650
--- /dev/null
+++ b/4d/cc231d473e27e8502fb8c253cd59e34207e072
@@ -0,0 +1,129 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1C686431FD6\r
+       for <notmuch@notmuchmail.org>; Mon, 10 Jun 2013 12:43:30 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id A9Olgg18tBj7 for <notmuch@notmuchmail.org>;\r
+       Mon, 10 Jun 2013 12:43:22 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 215D9431FC7\r
+       for <notmuch@notmuchmail.org>; Mon, 10 Jun 2013 12:43:22 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1Um7zm-0007mF-FZ; Mon, 10 Jun 2013 20:43:16 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1Um7zm-0004hz-6Z; Mon, 10 Jun 2013 20:43:14 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: update search sort order help to match code\r
+In-Reply-To: <1370282191-4526-1-git-send-email-jani@nikula.org>\r
+References: <1370282191-4526-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.15.2+171~ge2f30a2 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 10 Jun 2013 20:43:13 +0100\r
+Message-ID: <87obbdrbu6.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 5c8340a786be58f19cffd6c31c59ef00 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -0.0 points.\r
+       Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 10 Jun 2013 19:43:30 -0000\r
+\r
+\r
+LGTM +1\r
+\r
+Mark\r
+\r
+On Mon, 03 Jun 2013, Jani Nikula <jani@nikula.org> wrote:\r
+> ---\r
+>  emacs/notmuch-lib.el |    7 ++++++-\r
+>  emacs/notmuch.el     |   13 ++-----------\r
+>  2 files changed, 8 insertions(+), 12 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el\r
+> index 28f78e0..c43d5a9 100644\r
+> --- a/emacs/notmuch-lib.el\r
+> +++ b/emacs/notmuch-lib.el\r
+> @@ -68,7 +68,12 @@\r
+>    :group 'notmuch)\r
+>  \r
+>  (defcustom notmuch-search-oldest-first t\r
+> -  "Show the oldest mail first when searching."\r
+> +  "Show the oldest mail first when searching.\r
+> +\r
+> +This variable defines the default sort order for displaying\r
+> +search results. Note that any filtered searches created by\r
+> +`notmuch-search-filter' retain the search order of the parent\r
+> +search."\r
+>    :type 'boolean\r
+>    :group 'notmuch-search)\r
+>  \r
+> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> index 26ba7e7..cc62088 100644\r
+> --- a/emacs/notmuch.el\r
+> +++ b/emacs/notmuch.el\r
+> @@ -1030,17 +1030,8 @@ depending on the value of `notmuch-poll-script'."\r
+>  (defun notmuch-search-toggle-order ()\r
+>    "Toggle the current search order.\r
+>  \r
+> -By default, the \"inbox\" view created by `notmuch' is displayed\r
+> -in chronological order (oldest thread at the beginning of the\r
+> -buffer), while any global searches created by `notmuch-search'\r
+> -are displayed in reverse-chronological order (newest thread at\r
+> -the beginning of the buffer).\r
+> -\r
+> -This command toggles the sort order for the current search.\r
+> -\r
+> -Note that any filtered searches created by\r
+> -`notmuch-search-filter' retain the search order of the parent\r
+> -search."\r
+> +This command toggles the sort order for the current search. The\r
+> +default sort order is defined by `notmuch-search-oldest-first'."\r
+>    (interactive)\r
+>    (set 'notmuch-search-oldest-first (not notmuch-search-oldest-first))\r
+>    (notmuch-search-refresh-view))\r
+> -- \r
+> 1.7.10.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r