Re: [PATCH 15/17] nmbug-status: Quote the title when using it as an id

diff --git a/33/b87a4892c059b8881b429db255b16d3045b368 b/33/b87a4892c059b8881b429db255b16d3045b368
new file mode 100644 (file)
index 0000000..2c8fb17
--- /dev/null
+++ b/33/b87a4892c059b8881b429db255b16d3045b368
@@ -0,0 +1,76 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0D002431FBD\r
+       for <notmuch@notmuchmail.org>; Sun,  9 Feb 2014 01:34:52 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id FD6k5AfggLhm for <notmuch@notmuchmail.org>;\r
+       Sun,  9 Feb 2014 01:34:48 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8B95C431FBC\r
+       for <notmuch@notmuchmail.org>; Sun,  9 Feb 2014 01:34:48 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 26E9F1000B2;\r
+       Sun,  9 Feb 2014 11:34:40 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: "W. Trevor King" <wking@tremily.us>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 15/17] nmbug-status: Quote the title when using it as an\r
+ id\r
+In-Reply-To: <20140208231804.GE17142@odin.tremily.us>\r
+References: <cover.1391424512.git.wking@tremily.us>\r
+       <1e32bfd3b971aea8842fa29a3f7adc5a552a0f79.1391424512.git.wking@tremily.us>\r
+       <20140208231804.GE17142@odin.tremily.us>\r
+User-Agent: Notmuch/0.17+69~g761b031 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 09 Feb 2014 11:34:39 +0200\r
+Message-ID: <m2bnygzl1s.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 09 Feb 2014 09:34:52 -0000\r
+\r
+On Sun, Feb 09 2014, "W. Trevor King" <wking@tremily.us> wrote:\r
+\r
+> On Mon, Feb 03, 2014 at 02:59:33AM -0800, W. Trevor King wrote:\r
+>> +            if 'id' not in view:\r
+>> +                view['id'] = quote(view['title'])\r
+>\r
+> Stuff like href="#Maybe%20Ready%20%28Core%20and%20Emacs%29" wasn't\r
+> working for me on Firefox 24.2.0, so I've tweaked this commit to slug\r
+> titles instead of quoting them.  Pushed to my nmbug-status-python3\r
+> branch and queued for my v2 submission.\r
+\r
+$ git checkout nmbug-status-python3\r
+$ git pull --rebase\r
+$ ./devel/nmbug/nmbug-status\r
+\r
+Looks pretty good to me. I am not sure whether the commit messages should\r
+be *that* verbose, though...\r
+\r
+>\r
+> Cheers,\r
+> Trevor\r
+\r
+Tomi\r