ident.c: treat $EMAIL as giving user.email identity explicitly
authorJunio C Hamano <gitster@pobox.com>
Fri, 8 Jan 2010 16:01:10 +0000 (08:01 -0800)
committerJunio C Hamano <gitster@pobox.com>
Sun, 10 Jan 2010 17:43:22 +0000 (09:43 -0800)
The environment variable EMAIL has been honored since 28a94f8 (Fall back
to $EMAIL for missing GIT_AUTHOR_EMAIL and GIT_COMMITTER_EMAIL,
2007-04-28) as the end-user's wish to use the address as the identity.
When we use it, we should say we are explicitly given email by the user.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
ident.c

diff --git a/ident.c b/ident.c
index e67c5ad1e8800250f17793bc826d608429d08ae3..d4f614543deddd12ed58fb1db98fe523fb4df6ce 100644 (file)
--- a/ident.c
+++ b/ident.c
@@ -85,10 +85,11 @@ static void setup_ident(void)
        if (!git_default_email[0]) {
                const char *email = getenv("EMAIL");
 
-               if (email && email[0])
+               if (email && email[0]) {
                        strlcpy(git_default_email, email,
                                sizeof(git_default_email));
-               else {
+                       user_ident_explicitly_given |= IDENT_MAIL_GIVEN;
+               } else {
                        if (!pw)
                                pw = getpwuid(getuid());
                        if (!pw)