Re: [PATCH 2/4] emacs: Support a message-mode switch function in notmuch-mua

diff --git a/e6/234db67f084024adc844837bfbe868e0445105 b/e6/234db67f084024adc844837bfbe868e0445105
new file mode 100644 (file)
index 0000000..75118a3
--- /dev/null
+++ b/e6/234db67f084024adc844837bfbe868e0445105
@@ -0,0 +1,116 @@
+Return-Path: <schnouki@schnouki.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5CA5F429E25\r
+       for <notmuch@notmuchmail.org>; Tue, 11 Oct 2011 12:49:54 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.1\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 73oth+Igehjf for <notmuch@notmuchmail.org>;\r
+       Tue, 11 Oct 2011 12:49:53 -0700 (PDT)\r
+Received: from ks3536.kimsufi.com (schnouki.net [87.98.217.222])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9FE1D431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 11 Oct 2011 12:49:53 -0700 (PDT)\r
+Received: from odin.local (nancy.schnouki.net [78.238.0.45])\r
+       by ks3536.kimsufi.com (Postfix) with ESMTPSA id 05B446A06A9;\r
+       Tue, 11 Oct 2011 21:49:51 +0200 (CEST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=schnouki.net;\r
+       s=key-schnouki; t=1318362592;\r
+       bh=zq5orsiAhxMB6MtiWKqndVl7tNSiN8/wkNEXRL07+oo=;\r
+       h=From:To:Subject:In-Reply-To:References:Date:Message-ID:\r
+       MIME-Version:Content-Type;\r
+       b=fc1w7mAIhwlstYtPVyLg3HfsE07McFpqC0l5hratzFi7htHpI4GqraLIa2D/ehb8c\r
+       UYUQYaOQYZrlqvUURvt3HSLea7IByRbuGrUx1VHWYjZpJBlrNyjbLfUCC6IgPXO58h\r
+       kj/yJ5hvv1pTqTpvrZdmkyooWwycTO53vic5DRpw=\r
+From: Thomas Jost <schnouki@schnouki.net>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/4] emacs: Support a message-mode switch function in\r
+       notmuch-mua\r
+In-Reply-To: <877h4cc0bn.fsf@washington.ligo-wa.caltech.edu>\r
+References: <1317643438-31272-1-git-send-email-schnouki@schnouki.net>\r
+       <1317643438-31272-3-git-send-email-schnouki@schnouki.net>\r
+       <877h4cc0bn.fsf@washington.ligo-wa.caltech.edu>\r
+User-Agent: Notmuch/0.9_rc1-74-gdae3084 (http://notmuchmail.org)\r
+       Emacs/24.0.90.1 (x86_64-unknown-linux-gnu)\r
+Date: Tue, 11 Oct 2011 21:49:48 +0200\r
+Message-ID: <8739eztijn.fsf@schnouki.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 11 Oct 2011 19:49:54 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Mon, 10 Oct 2011 08:50:52 -0700, Jameson Graef Rollins <jrollins@finestr=\r
+ucture.net> wrote:\r
+> However, I find the customization variable a bit clunky.  Since I wasn't\r
+> presented with any options in the customization, I didn't know what to\r
+> put in.  I copy and pasted "switch-to-buffer-other-frame" into the\r
+> customization field but that didn't work since I didn't protect the\r
+> function name.  Finally I got it to work by putting in\r
+> "'switch-to-buffer-other-frame" (with the initial "'").\r
+>=20\r
+> So I definitely love this feature, but can we make the customization\r
+> work better so that it's easier for the user to figure out how to set\r
+> it?\r
+\r
+Heh, I had just tested it using "(setq ...)", not using M-x customize.\r
+And yes, when using the customization interface it's not clear at all.\r
+The problem is that the ":options" property of customizable variables\r
+is only useful for hooks or alists, not for functions (but that isn't\r
+documented anywhere, I had to dig in custom.el to find this).\r
+\r
+So I think the best way to make that clearer and easier to figure out is\r
+just to add more details in the docstring. I'll send a patch as a reply\r
+to this message.\r
+\r
+> Another question about this feature: how do you make the window\r
+> (frame) go away after the email is sent?\r
+\r
+I do this:\r
+    (add-hook 'message-sent-hook 'delete-frame)\r
+\r
+(added to the doc too).\r
+\r
+Thanks for your review :)\r
+\r
+=2D-=20\r
+Thomas/Schnouki\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQEcBAEBAgAGBQJOlJ3cAAoJEMPdciX+bh5IbUEH/iggjhul3tdzFHvzl3zfoVYt\r
+E5TBrG5jzHCMSG7W1ar3Y0Lqf2W51ftN6dDc7ovfn5cEAcu1GXO+rB03AdwAqAQh\r
+u69RAc5Ke5N7Uy8v3jPXMfzEmZ+iePzzZ9mp79lMF3naKQWUdbZBnTZWk5qn6hcD\r
+Kj3xCNltsk70Y96AG9HSJbPklwdPfNmnwd4v3aZW7Q9Hi4xQm0A7YfyM07JJVMqo\r
+qNrYPKfH0EwnbAk50N1L4CvuWTJzi6Cqgs8FnSDV5Zsxem9sNQcWIigU302uDFEj\r
+2TlXxJNxodX31aOzzcGGXOROmw3C9mZfgGHila+VW6y8EEp+l9z1hevovq02Fv4=\r
+=Svcj\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r