Re: [PATCH] emacs: Compute build dependencies to fix byte compile issues
authorAustin Clements <amdragon@MIT.EDU>
Sun, 19 May 2013 12:14:40 +0000 (08:14 +2000)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:54:50 +0000 (09:54 -0800)
8c/2ce2ce4dde2358aaaa7fccdddbb555040ae829 [new file with mode: 0644]

diff --git a/8c/2ce2ce4dde2358aaaa7fccdddbb555040ae829 b/8c/2ce2ce4dde2358aaaa7fccdddbb555040ae829
new file mode 100644 (file)
index 0000000..70d1e8e
--- /dev/null
@@ -0,0 +1,111 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 977CD431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 19 May 2013 05:14:53 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id hBdds7DU2Qge for <notmuch@notmuchmail.org>;\r
+       Sun, 19 May 2013 05:14:46 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU\r
+       [18.9.25.14])\r
+       by olra.theworths.org (Postfix) with ESMTP id A23A5431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 19 May 2013 05:14:46 -0700 (PDT)\r
+X-AuditID: 1209190e-b7f4f6d000005142-b5-5198c2354131\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+       by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id E3.D1.20802.532C8915; Sun, 19 May 2013 08:14:45 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH-1.MIT.EDU [18.9.28.11])\r
+       by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id r4JCEiV2030529; \r
+       Sun, 19 May 2013 08:14:45 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r4JCEgr6002584\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+       Sun, 19 May 2013 08:14:43 -0400\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1Ue2Vd-0007hu-NG; Sun, 19 May 2013 08:14:41 -0400\r
+Date: Sun, 19 May 2013 08:14:40 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH] emacs: Compute build dependencies to fix byte compile\r
+       issues\r
+Message-ID: <20130519121440.GE5999@mit.edu>\r
+References: <1368821611-24110-1-git-send-email-amdragon@mit.edu>\r
+       <87y5bbjk4q.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=iso-8859-1\r
+Content-Disposition: inline\r
+Content-Transfer-Encoding: 8bit\r
+In-Reply-To: <87y5bbjk4q.fsf@zancas.localnet>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsUixG6nrmt6aEagwaQ31hY3WrsZLa7fnMns\r
+       wOTxbNUtZo8th94zBzBFcdmkpOZklqUW6dslcGV8e7GaseA8Z8X3/xMYGxgXsHcxcnJICJhI\r
+       tPa+Z4OwxSQu3FsPZHNxCAnsY5SY0HCcEcLZyCgxpecOC4Rzmkli95PPzBDOEkaJl03bmEH6\r
+       WQRUJU53HmIBsdkENCS27V/OCGKLAMWvbpsMtoNZQFri2+9mJhBbWCBY4mbbCbB6XgFtiZPX\r
+       VoPZQgLJEot/rGCDiAtKnJz5hAWiV0di59Y7QHEOsDnL/3FAhOUlmrfOBjuBU0BX4uSJx2Dl\r
+       ogIqElNObmObwCg8C8mkWUgmzUKYNAvJpAWMLKsYZVNyq3RzEzNzilOTdYuTE/PyUot0jfVy\r
+       M0v0UlNKNzGCIoFTkm8H49eDSocYBTgYlXh4Nd5NDxRiTSwrrsw9xCjJwaQkyrty34xAIb6k\r
+       /JTKjMTijPii0pzU4kOMEhzMSiK8aROBcrwpiZVVqUX5MClpDhYlcd4rKTf9hQTSE0tSs1NT\r
+       C1KLYLIyHBxKEry8B4EaBYtS01Mr0jJzShDSTBycIMN5gIZfPwAyvLggMbc4Mx0if4pRUUqc\r
+       lwOkWQAkkVGaB9cLS1SvGMWBXhHmfQnSzgNMcnDdr4AGMwENZr02FWRwSSJCSqqBkXnC4S1v\r
+       Guq5b2x9qG986btDl/JV9q6HV5/u4u6ULXN/LerftDPwwNqwur2c05YxrVb7NEt+1iJRrq6v\r
+       qfY/3Rb7HeH4f8jg2U6PzTtSu85/aNl7eWLBYp7MKgGug/VTdGPbM4WNDQ1bWvh2i6kK/0jU\r
+       ur9ltlv6tMW7/8ftO3Mj5PtM+5Vn1JVYijMSDbWYi4oTAZW2MJ8vAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 19 May 2013 12:14:53 -0000\r
+\r
+Quoth David Bremner on May 19 at  8:15 am:\r
+> Austin Clements <amdragon@MIT.EDU> writes:\r
+> >\r
+> > This patch addresses these problems by computing make dependency rules\r
+> > from the (require 'x) forms in the Elisp source files, which we inject\r
+> > into make's dependency database.\r
+> \r
+> this seems to work as advertised.\r
+> \r
+> > +;;\r
+> > +;; Copyright © Austin Clements\r
+> \r
+> I guess you need a copyright year?\r
+\r
+Strangely, none of the Elisp files have copyright years.  But maybe\r
+they should?\r
+\r
+> > +      ;; Is it a (require 'x) form?\r
+> > +      (when (and (listp form) (= (length form) 2)\r
+> > +                 (eq (car form) 'require)\r
+> > +                 (listp (cadr form)) (= (length (cadr form)) 2)\r
+> > +                 (eq (car (cadr form)) 'quote)\r
+> > +                 (symbolp (cadr (cadr form))))\r
+> \r
+> This might be a corner case, but formally can't the argument to require\r
+> be a variable or even a function call? Maybe this never happens in\r
+> practice.\r
+\r
+That is technically true (really, it can be an arbitrary expression),\r
+but I don't have an environment in which to evaluate that expression,\r
+so I opted for only supporting the obvious static case, which also\r
+happens to be the only case that matters for the notmuch code.\r