Re: [PATCH] notmuch: Add "maildir:" search option

diff --git a/e3/e32c8f258e92217b1bde2aac1cec49afbe44d3 b/e3/e32c8f258e92217b1bde2aac1cec49afbe44d3
new file mode 100644 (file)
index 0000000..4594d1a
--- /dev/null
+++ b/e3/e32c8f258e92217b1bde2aac1cec49afbe44d3
@@ -0,0 +1,90 @@
+Return-Path: <peterz@infradead.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 166F0431E84\r
+       for <notmuch@notmuchmail.org>; Sun, 12 Jan 2014 08:06:31 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id fOW3e2nyM2CO for <notmuch@notmuchmail.org>;\r
+       Sun, 12 Jan 2014 08:06:23 -0800 (PST)\r
+Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 36CF1431E82\r
+       for <notmuch@notmuchmail.org>; Sun, 12 Jan 2014 08:06:23 -0800 (PST)\r
+Received: from dhcp-077-248-225-117.chello.nl ([77.248.225.117] helo=laptop)\r
+       by merlin.infradead.org with esmtpsa (Exim 4.80.1 #2 (Red Hat Linux))\r
+       id 1W2NYL-0002pl-UH; Sun, 12 Jan 2014 16:06:22 +0000\r
+Received: by laptop (Postfix, from userid 1000)\r
+       id BE02110806051; Sun, 12 Jan 2014 17:06:19 +0100 (CET)\r
+Date: Sun, 12 Jan 2014 17:06:19 +0100\r
+From: Peter Zijlstra <peterz@infradead.org>\r
+To: Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH] notmuch: Add "maildir:" search option\r
+Message-ID: <20140112160619.GM7572@laptop.programming.kicks-ass.net>\r
+References: <20131112155637.GA16796@laptop.programming.kicks-ass.net>\r
+       <8761ppurfz.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <8761ppurfz.fsf@nikula.org>\r
+User-Agent: Mutt/1.5.21 (2012-12-30)\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 12 Jan 2014 16:06:31 -0000\r
+\r
+On Sun, Jan 12, 2014 at 05:53:52PM +0200, Jani Nikula wrote:\r
+> On Tue, 12 Nov 2013, Peter Zijlstra <peterz@infradead.org> wrote:\r
+> > Subject: notmuch: Add "maildir:" search option\r
+> >\r
+> > The current "folder:" search terms are near useless when you have\r
+> > recursive folders, introduce a boolean "maildir:" search term to\r
+> > exactly match the maildir folder.\r
+> \r
+> Hi Peter -\r
+> \r
+> Per some discussion on IRC about the usefulness of the current "folder:"\r
+> prefix, I went ahead and sent patches to make "folder:" a boolean prefix\r
+> [1]. It's not the same as your "maildir:" implementation, but I believe\r
+> you could use it to achieve the things you want with that. In\r
+> particular, my proposed "folder:" prefix is the literal path from\r
+> maildir root, and does not make any assumptions about maildir - i.e. it\r
+> requires the final cur/new too. (That can be useful for some mutt users\r
+> who need the cur/new distinction.)\r
+> \r
+> I am not opposed to adding another prefix like "maildir:" that does make\r
+> assumptions on the mail storage and transformations on the path, but I\r
+> do think it would be less important with the boolean "folder:" in place.\r
+\r
+Right, sorry for disappearing; I failed to find time to finish the\r
+patch.\r
+\r
+I did actually modify it do loose the /new,/cur bits and I think I\r
+addressed all other comments, including the file removal part.\r
+\r
+Where I got 'stuck' was writing test cases.\r
+\r
+Anyway, I'll try and have a look at the recent notmuch.git and see if it\r
+does what I'd like it to.\r
+\r
+Thanks for getting back to me.\r
+\r
+~ Peter\r