--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 5579E431FC0\r
+ for <notmuch@notmuchmail.org>; Tue, 7 Aug 2012 08:13:52 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id qdBPo6w8ccsT for <notmuch@notmuchmail.org>;\r
+ Tue, 7 Aug 2012 08:13:51 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 855D5431FAF\r
+ for <notmuch@notmuchmail.org>; Tue, 7 Aug 2012 08:13:51 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SylTf-0007rQ-D3; Tue, 07 Aug 2012 16:13:47 +0100\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+ helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SylTf-0006Bh-3y; Tue, 07 Aug 2012 16:13:47 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Michal Nazarewicz <mpn@google.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] notmuch-show: add notmuch-show-auto-mark-read option\r
+In-Reply-To:\r
+ <7c2931eb4d34ff78e4c73d721bc00dc60d185e6a.1344260116.git.mina86@mina86.com>\r
+References:\r
+ <7c2931eb4d34ff78e4c73d721bc00dc60d185e6a.1344260116.git.mina86@mina86.com>\r
+User-Agent: Notmuch/0.13.2+96~g634443c (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 07 Aug 2012 16:13:40 +0100\r
+Message-ID: <874noepwez.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 13dee221bff979a4c103cbb06fa6f317 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+ * domain\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 07 Aug 2012 15:13:52 -0000\r
+\r
+On Mon, 06 Aug 2012, Michal Nazarewicz <mpn@google.com> wrote:\r
+> From: Michal Nazarewicz <mina86@mina86.com>\r
+>\r
+> Setting `notmuch-show-auto-mark-read' to nil stops notmuch-show from marking\r
+> the message as read (by removing the unread tag). Inteded for people who\r
+> like to mark messages read explicitly.\r
+> ---\r
+> emacs/notmuch-show.el | 16 +++++++++++++---\r
+> 1 files changed, 13 insertions(+), 3 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index d318430..85a17b1 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -183,6 +183,14 @@ provided with an MLA argument nor `completing-read' input."\r
+> notmuch-show-stash-mlarchive-link-alist))\r
+> :group 'notmuch-show)\r
+> \r
+> +(defcustom notmuch-show-auto-mark-read t\r
+> + "Whether to automatically mark message as read when it is shown. If\r
+> +nil, message needs to be marked as read manually for instance by\r
+> +removing the unread tag."\r
+> + :type 'boolean\r
+> + :group 'notmuch-show)\r
+> +\r
+> +\r
+> (defmacro with-current-notmuch-show-message (&rest body)\r
+> "Evaluate body with current buffer set to the text of current message"\r
+> `(save-excursion\r
+> @@ -1374,9 +1382,11 @@ current thread."\r
+> "Are the headers of the current message visible?"\r
+> (notmuch-show-get-prop :headers-visible))\r
+> \r
+> -(defun notmuch-show-mark-read ()\r
+> - "Mark the current message as read."\r
+> - (notmuch-show-tag-message "-unread"))\r
+> +(defun notmuch-show-mark-read (&optional force)\r
+> + "Mark the current message as read if FORCE or\r
+> +`notmuch-show-auto-mark-read' is non-nil."\r
+> + (when (or force notmuch-show-auto-mark-read)\r
+> + (notmuch-show-tag-message "-unread")))\r
+\r
+\r
+As an alternative approach would allowing a list of tags (or even tag\r
+changes) to apply when a message is "read" do what you want and be more\r
+flexible? I am thinking of something roughly analogous to\r
+notmuch-message-replied-tags. I can imagine some people would like to\r
+remove the inbox tag automatically for example. (And since we sync with\r
+maildir flags the exact tag name does matter).\r
+\r
+\r
+I agree with Austin that the current unread marking is a little\r
+weird/unpredictable (eg notmuch-show-next-message marks a message read\r
+even if it is closed) but I don't think fixing that helps your use.\r
+\r
+Best wishes \r
+\r
+Mark\r
+\r
+\r
projects / notmuch-archives.git / commitdiff