Re: [PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub
authorDavid Bremner <david@tethera.net>
Sat, 22 Feb 2014 01:21:19 +0000 (21:21 +2000)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:00:07 +0000 (10:00 -0800)
e1/c192400f3705d4cd6193ad210a2f383f1fa90b [new file with mode: 0644]

diff --git a/e1/c192400f3705d4cd6193ad210a2f383f1fa90b b/e1/c192400f3705d4cd6193ad210a2f383f1fa90b
new file mode 100644 (file)
index 0000000..7611a6b
--- /dev/null
@@ -0,0 +1,64 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 176DB431FBD\r
+       for <notmuch@notmuchmail.org>; Fri, 21 Feb 2014 17:21:34 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id NsvfKDZN0QSf for <notmuch@notmuchmail.org>;\r
+       Fri, 21 Feb 2014 17:21:26 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D87B4431FB6\r
+       for <notmuch@notmuchmail.org>; Fri, 21 Feb 2014 17:21:26 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1WH1HQ-0007vl-Oq; Fri, 21 Feb 2014 21:21:24 -0400\r
+Received: (nullmailer pid 31316 invoked by uid 1000); Sat, 22 Feb 2014\r
+       01:21:19 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/1] nmbug-status: replace __values__() with values() in\r
+       OrderedDict stub\r
+In-Reply-To: <1392748492-29341-1-git-send-email-tomi.ollila@iki.fi>\r
+References: <1392748492-29341-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 21 Feb 2014 21:21:19 -0400\r
+Message-ID: <87bny0x7qo.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 22 Feb 2014 01:21:34 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> Python dict() object does not have __values__() function which\r
+> OrderedDict().values() (the stub provided in nmbug-status) could call\r
+> to provide ordered list of values. By renaming this thinko to\r
+> values() will make our stub work as expected -- dict items listed out\r
+> in order those were added to the dictionary.\r
+\r
+pushed, and it looks like it fixes the date ordering problem\r
+\r
+d\r