Re: [PATCH v2] new: Detect dirent.d_type support at configure time
authorTomi Ollila <tomi.ollila@iki.fi>
Thu, 13 Feb 2014 06:55:19 +0000 (08:55 +0200)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:59:56 +0000 (09:59 -0800)
06/a48cda76f584975c8d4c8cfbfbb6bc7097c225 [new file with mode: 0644]

diff --git a/06/a48cda76f584975c8d4c8cfbfbb6bc7097c225 b/06/a48cda76f584975c8d4c8cfbfbb6bc7097c225
new file mode 100644 (file)
index 0000000..566e8cf
--- /dev/null
@@ -0,0 +1,67 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 17325431FBD\r
+       for <notmuch@notmuchmail.org>; Wed, 12 Feb 2014 22:55:31 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 3mLiRITeP7rm for <notmuch@notmuchmail.org>;\r
+       Wed, 12 Feb 2014 22:55:26 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 39472431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 12 Feb 2014 22:55:26 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id D44401000FA;\r
+       Thu, 13 Feb 2014 08:55:19 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] new: Detect dirent.d_type support at configure time\r
+In-Reply-To: <1392274259-19765-1-git-send-email-amdragon@mit.edu>\r
+References: <1392274259-19765-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.17+69~g761b031 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 13 Feb 2014 08:55:19 +0200\r
+Message-ID: <m2y51f7b8o.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 13 Feb 2014 06:55:31 -0000\r
+\r
+On Thu, Feb 13 2014, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> Support for dirent.d_type is OS-specific.  Previously, we used\r
+> _DIRENT_HAVE_D_TYPE to detect support for this, but this is apparently\r
+> a glic-ism (FreeBSD, for example, supports d_type, but does not define\r
+> this).  Since there's no cross-platform way to detect support for\r
+> dirent.d_type, detect it using a test compile at configure time.\r
+> ---\r
+> This is a trivial rebase of\r
+> id:1385262952-29240-1-git-send-email-amdragon@mit.edu, which I\r
+> apparently never got around to sending.  Tomi and Jani checked off v1\r
+> of this patch, so I'm marking it ready.\r
+\r
+Looks good. Applies cleanly. Tests pass.\r
+\r
+Tomi\r
+\r