Re: [Patch (rebased) 0/2] contrib: pick: remove an unused variable
authorTomi Ollila <tomi.ollila@iki.fi>
Mon, 26 Aug 2013 18:36:01 +0000 (21:36 +0300)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:56:39 +0000 (09:56 -0800)
75/fb55091683ce543558c2489272a409e1bf1b6a [new file with mode: 0644]

diff --git a/75/fb55091683ce543558c2489272a409e1bf1b6a b/75/fb55091683ce543558c2489272a409e1bf1b6a
new file mode 100644 (file)
index 0000000..41da294
--- /dev/null
@@ -0,0 +1,87 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 324B8431FD7\r
+       for <notmuch@notmuchmail.org>; Mon, 26 Aug 2013 11:36:12 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id BPUY-bZOL0Rx for <notmuch@notmuchmail.org>;\r
+       Mon, 26 Aug 2013 11:36:07 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 714CF431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 26 Aug 2013 11:36:07 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 432E3100030;\r
+       Mon, 26 Aug 2013 21:36:01 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [Patch (rebased) 0/2] contrib: pick: remove an unused variable\r
+In-Reply-To: <1377460214-4795-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1377460214-4795-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.16+36~g947c286 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 26 Aug 2013 21:36:01 +0300\r
+Message-ID: <m2ob8ke1v2.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 26 Aug 2013 18:36:12 -0000\r
+\r
+On Sun, Aug 25 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> This is a rebased version of\r
+> id:1372712861-13515-1-git-send-email-markwalters1009@gmail.com.\r
+>  \r
+> When documenting notmuch-pick-worker I realised that\r
+> notmuch-pick-buffer-name was an essentially unused argument: it is\r
+> only used to reset itself on refresh.\r
+>\r
+> (Possibly this was a mis-copy from notmuch-show or possibly a left\r
+> over from refesh used kill-buffer instead of erase-buffer.)\r
+>\r
+> In any case we might as well remove it and then document the function.\r
+\r
+LGTM.\r
+\r
+Tomi\r
+\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+> Mark Walters (2):\r
+>   contrib: pick: remove unneeded variable notmuch-pick-buffer-name\r
+>   contrib: pick: add docstring for notmuch-pick-worker\r
+>\r
+>  contrib/notmuch-pick/notmuch-pick.el |   19 ++++++++-----------\r
+>  1 files changed, 8 insertions(+), 11 deletions(-)\r
+>\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r