Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

diff --git a/a8/624d1697a8633c2482e7d4f7d29355b640a4c6 b/a8/624d1697a8633c2482e7d4f7d29355b640a4c6
new file mode 100644 (file)
index 0000000..ad57251
--- /dev/null
+++ b/a8/624d1697a8633c2482e7d4f7d29355b640a4c6
@@ -0,0 +1,99 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2B335431FAF\r
+       for <notmuch@notmuchmail.org>; Fri, 20 Jan 2012 12:20:27 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 4NfBW6ZYwaCM for <notmuch@notmuchmail.org>;\r
+       Fri, 20 Jan 2012 12:20:26 -0800 (PST)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 97A81431FAE\r
+       for <notmuch@notmuchmail.org>; Fri, 20 Jan 2012 12:20:26 -0800 (PST)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by earth-doxen-postvirus (Postfix) with ESMTP id 331CD66E0012;\r
+       Fri, 20 Jan 2012 12:20:26 -0800 (PST)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (m17.ligo.caltech.edu [131.215.115.117])\r
+       (Authenticated sender: jrollins)\r
+       by earth-doxen-submit (Postfix) with ESMTP id 71B8466E0124;\r
+       Fri, 20 Jan 2012 12:20:23 -0800 (PST)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id 490112EA; Fri, 20 Jan 2012 12:20:23 -0800 (PST)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/3] emacs: Don't return the button from\r
+       `notmuch-show-insert-part-header'.\r
+In-Reply-To: <1327052612-1040-2-git-send-email-dme@dme.org>\r
+References: <1327052612-1040-1-git-send-email-dme@dme.org>\r
+       <1327052612-1040-2-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.11+92~g9b8f34f (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 20 Jan 2012 12:20:20 -0800\r
+Message-ID: <87zkdiktx7.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 20 Jan 2012 20:20:27 -0000\r
+\r
+--=-=-=\r
+\r
+On Fri, 20 Jan 2012 09:43:31 +0000, David Edmondson <dme@dme.org> wrote:\r
+> The buttons inserted for encrypted parts are slightly different now -\r
+> previously the logic was that if a part was encrypted it would have\r
+> the signature status inserted only if the encryption status was\r
+> specified. Now the signature status will be inserted even without\r
+> encryption status. My reading of the documentation says that this is\r
+> correct, but I'm no expert. Comments?\r
+\r
+I need some more time to review this patch, but I don't think this is\r
+correct.  The signature status of encrypted messages (or even if the\r
+message was signed at all) comes from the decryption process.  They're\r
+not independent.  If the decryption fails it's unknown if there was a\r
+signature or not.\r
+\r
+I need to look closer at this, though.  Hopefully this weekend.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPGcyEAAoJEO00zqvie6q8makP/1oBgbpfEWTPR1nAGoGA8I6P\r
+EzEBnIpf6gmrMc4evwTG4toJAMsiSqcJTvMny/3yqYK4sNP7fbGefxDh/BG1zaPm\r
+OMfVp2xkqelubiAgmma+s0WT0hSUdhqZMrV4HX22RHJTcgz/MSGC+ZeAQv4wajh0\r
+iCyCdjFHsG3SirJa7OEZR+IqcZKvmEEgJLpAPW3/1q/gBwBBIWoWIu04z60vkMGa\r
+byFBiiipYvLqE0I0ssmWCMkssgsOoZMSMd8NGOJJOOKcX/yZyeiDv9aey7dM6qQZ\r
+ziWnJmfO2ApK0r47jWWvaes6CRQUeEEal+79uIonAaZcJR/CGOeG1Fu6Qg75TVbP\r
+nK7CxZxHM4AsGsmBJbKFDN0NnQhhOuyfdSBCWsd+oOWyJfKa/lKmMomywIAt7MFw\r
+rwV5u825T5aeH463hiEBSKbqNiHTjCBW0F964/JiqGUiJsMrSnptfyidEIjEHGet\r
+i2WwDcacg7mmDq44ES9XC90zseQ9wRpCjofqmlfs1KmTJrYFdxHuHYcrUjZVg5vN\r
+no74/wPpF2EfFqW2ocIRxo9QbnaFs/HgYu1pzalQ+p9MryfIctWYGFcPsPpvZE5U\r
+v6+1oUpBGLXu0e+NxSoQSR9uvuVVMj23iMuGb1p22PVbS2VI44i/UuKYkXIWKRjQ\r
++0bzkYuojSQwrf3zgWiI\r
+=n7oz\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r