Re: [PATCH 1/5] util: Factor out boolean term quoting routine

diff --git a/5e/858a58e7cf36c636623e5e92af96ab208750a4 b/5e/858a58e7cf36c636623e5e92af96ab208750a4
new file mode 100644 (file)
index 0000000..dd423c4
--- /dev/null
+++ b/5e/858a58e7cf36c636623e5e92af96ab208750a4
@@ -0,0 +1,74 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E850F431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 25 Dec 2012 04:26:24 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id NGzCUqkESBgZ for <notmuch@notmuchmail.org>;\r
+       Tue, 25 Dec 2012 04:26:24 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 9022C431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 25 Dec 2012 04:26:24 -0800 (PST)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1TnTaM-0001Ot-6D; Tue, 25 Dec 2012 08:26:18 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1TnTZv-0003Pv-AX; Tue, 25 Dec 2012 08:25:51 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/5] util: Factor out boolean term quoting routine\r
+In-Reply-To: <1356415076-5692-2-git-send-email-amdragon@mit.edu>\r
+References: <1356415076-5692-1-git-send-email-amdragon@mit.edu>\r
+       <1356415076-5692-2-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.14+213~g4af1ac6 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 25 Dec 2012 08:25:51 -0400\r
+Message-ID: <87wqw6e2sw.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 25 Dec 2012 12:26:25 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+>\r
+> This could live in tag-util as well, but it is really nothing specific\r
+> to tags (although the conventions are specific to Xapian).\r
+>\r
+> Furthermore, this now combines the term prefix with the quoted term;\r
+> arguably this is just as easy to do in the caller, but this will\r
+> nicely parallel the boolean term parsing function to be introduced\r
+> shortly.\r
+\r
+At first glance, I found this a bit too notmuch-specific to go in\r
+util. On second glance, I found my first reaction somewhat\r
+bizarre. Perhaps at some point we should drop a README file in util\r
+explaining what should go there.\r
+\r
+Other than that, LGTM\r
+d\r