Re: [notmuch] [PATCH] Produce valid JSON output even if mail body is empty

diff --git a/7e/afd1091658edde0271af9b7e70629a8adb678b b/7e/afd1091658edde0271af9b7e70629a8adb678b
new file mode 100644 (file)
index 0000000..283ec61
--- /dev/null
+++ b/7e/afd1091658edde0271af9b7e70629a8adb678b
@@ -0,0 +1,66 @@
+Return-Path: <james@jameswestby.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3A6594048F5\r
+       for <notmuch@notmuchmail.org>; Sun, 14 Mar 2010 12:01:34 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.866\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.866 tagged_above=-999 required=5\r
+       tests=[AWL=-0.867, BAYES_50=0.001] autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ivMi0VwZ6W3y for <notmuch@notmuchmail.org>;\r
+       Sun, 14 Mar 2010 12:01:33 -0700 (PDT)\r
+Received: from jameswestby.net (jameswestby.net [89.145.97.141])\r
+       by olra.theworths.org (Postfix) with ESMTP id 34A3A454968\r
+       for <notmuch@notmuchmail.org>; Sun, 14 Mar 2010 12:01:33 -0700 (PDT)\r
+Received: from [74.220.175.184] (helo=flash)\r
+       by jameswestby.net with esmtpa (Exim 4.69)\r
+       (envelope-from <james@jameswestby.net>)\r
+       id 1Nqt47-00048z-BI; Sun, 14 Mar 2010 19:01:31 +0000\r
+Received: by flash (Postfix, from userid 1000)\r
+       id B3699605C14; Sun, 14 Mar 2010 15:01:28 -0400 (EDT)\r
+From: James Westby <jw+debian@jameswestby.net>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+In-Reply-To: <1268590751-7478-1-git-send-email-sojkam1@fel.cvut.cz>\r
+References: <87mxyabwha.fsf@steelpick.localdomain>\r
+       <1268590751-7478-1-git-send-email-sojkam1@fel.cvut.cz>\r
+Date: Sun, 14 Mar 2010 15:01:28 -0400\r
+Message-ID: <87ociqbud3.fsf@jameswestby.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Subject: Re: [notmuch] [PATCH] Produce valid JSON output even if mail body\r
+ is empty\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 14 Mar 2010 19:01:34 -0000\r
+\r
+On Sun, 14 Mar 2010 19:19:11 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+> Mails with empty body produced the following output:\r
+>   "body": [{"id": 1, "content-type": "text/plain", "content": (null)}]\r
+> The (null) is not valid JSON syntax.\r
+\r
+Is this just something that can happen with the body?\r
+\r
+I've see (null) in the emacs interface when I've done something silly\r
+such as opening a newer notmuch db with an old client.\r
+\r
+Should all the attributes be guarded in a similar manner to ensure valid\r
+JSON?\r
+\r
+Thanks,\r
+\r
+James\r