Re: notmuch-0.16: realpath() compatibility issue; clang visibility problem

diff --git a/1d/9b2fd02ca6d3d1d2564b675d28fc0f13f1fbc3 b/1d/9b2fd02ca6d3d1d2564b675d28fc0f13f1fbc3
new file mode 100644 (file)
index 0000000..c1d6715
--- /dev/null
+++ b/1d/9b2fd02ca6d3d1d2564b675d28fc0f13f1fbc3
@@ -0,0 +1,86 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8AEE4431FC0\r
+       for <notmuch@notmuchmail.org>; Sat,  4 Jan 2014 05:06:54 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id fekfjVMx167Q for <notmuch@notmuchmail.org>;\r
+       Sat,  4 Jan 2014 05:06:46 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id A59C2431FBD\r
+       for <notmuch@notmuchmail.org>; Sat,  4 Jan 2014 05:06:46 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 26F931000B2;\r
+       Sat,  4 Jan 2014 15:06:39 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Thomas Klausner <tk@giga.or.at>\r
+Subject: Re: notmuch-0.16: realpath() compatibility issue;\r
+       clang visibility problem\r
+In-Reply-To: <20140104125358.GW27614@danbala.tuwien.ac.at>\r
+References: <20140103214735.GG27614@danbala.tuwien.ac.at>\r
+       <CAB+hUn-8eyY07y3j1N3JJLQ3qWVEVPoGWHcUVkovg34xH0ZOwQ@mail.gmail.com>\r
+       <sfid-H20140104-134644-+055.78-1@spamfilter.osbf.lua>\r
+       <CAB+hUn-ov+2roT-tVTcjuPbckiTkRPtUxazfmY1KFeeVoMQJCA@mail.gmail.com>\r
+       <20140104125358.GW27614@danbala.tuwien.ac.at>\r
+User-Agent: Notmuch/0.17+13~gdfcf116 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 04 Jan 2014 15:06:38 +0200\r
+Message-ID: <m2eh4n521t.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 04 Jan 2014 13:06:54 -0000\r
+\r
+On Sat, Jan 04 2014, Thomas Klausner <tk@giga.or.at> wrote:\r
+\r
+> On Sat, Jan 04, 2014 at 02:46:37PM +0200, Jani Nikula wrote:\r
+>> I guess we should look at realpath() compatibility, but in fairness passing\r
+>> NULL for the second parameter is according to POSIX.1-2008, not glibc\r
+>> extension.\r
+>\r
+> Ah, interesting.\r
+>\r
+> I can file a bug report with NetBSD about that, but in the meantime,\r
+> it causes a coredump. :|\r
+\r
+The linux namual page (*) has good explanation of this in the BUGS section\r
+\r
+(*) http://man7.org/linux/man-pages/man3/realpath.3.html\r
+\r
+\r
+After reading that I think fixing that is not as simple as your previous\r
+patch does it -- so probably you just have to keep patching your system\r
+until NetBSD library realpath() is POSIX.1-2008 -compatible.\r
+\r
+Note that having users' own patches in their systems is not uncommon\r
+at all :D\r
+\r
+\r
+>\r
+> Thanks,\r
+>  Thomas\r
+\r
+Tomi\r