Re: notmuch-reply date format

diff --git a/f1/cd3b28fbd97e978ae1b912cdf59bda2806decc b/f1/cd3b28fbd97e978ae1b912cdf59bda2806decc
new file mode 100644 (file)
index 0000000..931f91a
--- /dev/null
+++ b/f1/cd3b28fbd97e978ae1b912cdf59bda2806decc
@@ -0,0 +1,112 @@
+Return-Path: <sramov@pobox.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 59063431FBD\r
+       for <notmuch@notmuchmail.org>; Tue, 15 Jul 2014 00:35:43 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.099\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.099 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       RCVD_IN_DNSWL_NONE=-0.0001, UNPARSEABLE_RELAY=0.001]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id AMRCn3e33ylZ for <notmuch@notmuchmail.org>;\r
+       Tue, 15 Jul 2014 00:35:38 -0700 (PDT)\r
+Received: from smtp.pobox.com (smtp.pobox.com [208.72.237.35])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8FC86431FBC\r
+       for <notmuch@notmuchmail.org>; Tue, 15 Jul 2014 00:35:38 -0700 (PDT)\r
+Received: from smtp.pobox.com (unknown [127.0.0.1])\r
+       by pb-smtp0.pobox.com (Postfix) with ESMTP id 91CB6220C5;\r
+       Tue, 15 Jul 2014 03:35:20 -0400 (EDT)\r
+DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=date\r
+       :message-id:from:subject:to:cc:in-reply-to:references; s=sasl;\r
+       bh=MiD5mCraUGQ7csJ39G8cniz20Bw=; b=WWrgXuZPNbalCewKlN+gLvPdWIl+\r
+       6P1RR+/8gySr+JNNXGbNDhSKbCBDjfiSC4SLCSlUiYkz6s6cH3IrVuWzNY9xjADE\r
+       tqXX2uy5jj64CGbqX/MoRT3p5AvCdBZHzIRK7AGgEM+DIj+zcESGbx0rcXqaEh3B\r
+       DatbxmlRyXog/vM=\r
+DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=date:message-id\r
+       :from:subject:to:cc:in-reply-to:references; q=dns; s=sasl; b=IyQ\r
+       352aWJnn07cwF+ES5Dcj13okUmIRuCZ8G5JKp3/y1J4NirgabYpaAWHluugHLekG\r
+       BupIYpb3eA4PUkUQqNQ6QhGmjgoDyzTDfA2Wp4XphBD10+4yK3FkDCDXvqINGw0q\r
+       wTZzSy+u4Fk1Y99b4xKZioh1EX7YNOblLoQqhbUA=\r
+Received: from pb-smtp0.int.icgroup.com (unknown [127.0.0.1])\r
+       by pb-smtp0.pobox.com (Postfix) with ESMTP id 85C1F220C4;\r
+       Tue, 15 Jul 2014 03:35:20 -0400 (EDT)\r
+Received: from ouroboros.ramov.inet (unknown [178.218.165.9])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by pb-smtp0.pobox.com (Postfix) with ESMTPSA id 979BA220BF;\r
+       Tue, 15 Jul 2014 03:35:14 -0400 (EDT)\r
+Received: from localhost (1000@localhost [local]);\r
+       by localhost (OpenSMTPD) with ESMTPA id f57c85c6;\r
+       Tue, 15 Jul 2014 09:35:30 +0200 (CEST)\r
+Date: Tue, 15 Jul 2014 09:35:30 +0200 (CEST)\r
+Message-Id: <702358554056882337.enqueue@ouroboros.ramov.inet>\r
+From: Sime Ramov <sramov@pobox.com>\r
+Subject: Re: notmuch-reply date format\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+In-Reply-To: <20140714130431.GB4660@mit.edu>\r
+References: <1722345767858996112.enqueue@ouroboros.ramov.inet>\r
+       <20140714130431.GB4660@mit.edu>\r
+X-Pobox-Relay-ID:\r
+ 8FB27B22-0BF2-11E4-BBE4-9903E9FBB39C-45584858!pb-smtp0.pobox.com\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 15 Jul 2014 07:35:43 -0000\r
+\r
+Hello,\r
+\r
+* Austin Clements <amdragon@MIT.EDU> [Mon, 14 Jul 2014 09:04:31 -0400]:\r
+> Assuming the CLI is the right place for you to change this, you\r
+> probably want to call notmuch_message_get_date, then localtime, then\r
+> strftime.\r
+\r
+Tried to get this working to no avail. Not a programmer obviously :) I\r
+cobbled this together from various online sources:\r
+\r
+diff --git a/notmuch-reply.c b/notmuch-reply.c\r
+index 7c1c809..16cf19c 100644\r
+--- a/notmuch-reply.c\r
++++ b/notmuch-reply.c\r
+@@ -44,9 +44,15 @@ format_part_reply (mime_node_t *node)\r
+     int i;\r
+ \r
+     if (node->envelope_file) {\r
+-      printf ("On %s, %s wrote:\n",\r
+-              notmuch_message_get_header (node->envelope_file, "date"),\r
+-              notmuch_message_get_header (node->envelope_file, "from"));\r
++      struct tm *info;\r
++      char dbuf[30];\r
++\r
++      info = localtime(notmuch_message_get_date(node->envelope_file));\r
++\r
++      strftime(dbuf, sizeof(dbuf), "%F %R %z", info);\r
++      printf ("* %s [%s]:\n",\r
++              notmuch_message_get_header(node->envelope_file, "from"), dbuf);\r
++\r
+     } else if (GMIME_IS_MESSAGE (node->part)) {\r
+       GMimeMessage *message = GMIME_MESSAGE (node->part);\r
+       InternetAddressList *recipients;\r
+\r
+When compiling I get this warning:\r
+\r
+notmuch-reply.c: In function 'format_part_reply':\r
+notmuch-reply.c:50: warning: passing argument 1 of 'localtime' makes pointer from integer without a cast\r
+\r
+And a core dump when notmuch reply is invoked on a message. Am I even\r
+close? :) Thanks\r