Re: [PATCH 1/3] cli: add insert --must-index option

diff --git a/fe/1a871fb0800ac312b5470533610b47b7dd13b7 b/fe/1a871fb0800ac312b5470533610b47b7dd13b7
new file mode 100644 (file)
index 0000000..a89bf3a
--- /dev/null
+++ b/fe/1a871fb0800ac312b5470533610b47b7dd13b7
@@ -0,0 +1,90 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 52619429E32\r
+       for <notmuch@notmuchmail.org>; Wed, 23 Oct 2013 17:05:52 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Gtioy34PkaA2 for <notmuch@notmuchmail.org>;\r
+       Wed, 23 Oct 2013 17:05:46 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id C5597429E29\r
+       for <notmuch@notmuchmail.org>; Wed, 23 Oct 2013 17:05:46 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1VZ8Qj-0000Ea-2P; Wed, 23 Oct 2013 21:05:37 -0300\r
+Received: (nullmailer pid 3578 invoked by uid 1000); Thu, 24 Oct 2013\r
+       00:05:33 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH 1/3] cli: add insert --must-index option\r
+In-Reply-To: <20131023193209.GF20337@mit.edu>\r
+References: <1374365254-13227-1-git-send-email-novalazy@gmail.com>\r
+       <87ip048gbj.fsf@qmul.ac.uk> <20130727151510.GA13750@hili.localdomain>\r
+       <87hadtxfrr.fsf@qmul.ac.uk> <20130912001349.GA18821@hili.localdomain>\r
+       <87zjqhv264.fsf@zancas.localnet> <m238o9fguj.fsf@guru.guru-group.fi>\r
+       <87bo2xtdp2.fsf@unb.ca> <m2eh7bu7t5.fsf@guru.guru-group.fi>\r
+       <20131023193209.GF20337@mit.edu>\r
+User-Agent: Notmuch/0.16+97~g6878b0b (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 23 Oct 2013 21:05:33 -0300\r
+Message-ID: <87ob6fv8he.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 24 Oct 2013 00:05:52 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> And in libnotmuch, we would do something like\r
+>\r
+> notmuch_status_t\r
+> notmuch_database_open (const char *path,\r
+>                        notmuch_database_mode_t mode,\r
+>                        const notmuch_options_t *options,\r
+>                        notmuch_database_t **database)\r
+> {\r
+>     notmuch_option_t real_options = NOTMUCH_OPTIONS_INIT;\r
+>     if (real_options.options_length < options.options_length)\r
+>         return error;\r
+>     memmove(&real_options, options, options.options_length);\r
+>     // ...\r
+> }\r
+>\r
+\r
+Does the C standard guarantee that if two structs have the same initial\r
+set of members, that they are aligned in a compatible way? I suppose it\r
+must work, but I'm still curious.\r
+\r
+Yet another approach would be to pass in array of descriptors, something\r
+like the command line argument parsing code does now.\r
+\r
+libnotmuch_opt_desc_t options[] = {\r
+  { LIBNOTMUCH_OPT_LOGHOOK, loghook },\r
+  { 0, 0} \r
+}\r
+\r
+I guess passing a (void *) as the second element of the pair?\r
+\r
+Of course it's a bit more work to unpack this way.\r