Re: [PATCH 2/5] configure, test: Added variables for paths to true and false.

diff --git a/9d/5700733de76d500988a5e839767a4d4ccd9c81 b/9d/5700733de76d500988a5e839767a4d4ccd9c81
new file mode 100644 (file)
index 0000000..a090cfb
--- /dev/null
+++ b/9d/5700733de76d500988a5e839767a4d4ccd9c81
@@ -0,0 +1,100 @@
+Return-Path: <cceleri@cs.stanford.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 69003431FBF\r
+       for <notmuch@notmuchmail.org>; Thu,  8 May 2014 08:00:20 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id xqmVuDN3wHIE for <notmuch@notmuchmail.org>;\r
+       Thu,  8 May 2014 08:00:12 -0700 (PDT)\r
+Received: from smtp1.cs.Stanford.EDU (smtp1.cs.Stanford.EDU [171.64.64.25])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 868AD431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  8 May 2014 08:00:12 -0700 (PDT)\r
+Received: from c-24-11-133-78.hsd1.sc.comcast.net ([24.11.133.78]\r
+       helo=jane.lan)\r
+       by smtp1.cs.Stanford.EDU with esmtpsa (UNKNOWN:AES128-GCM-SHA256:128)\r
+       (Exim 4.80.1) (envelope-from <cceleri@cs.stanford.edu>)\r
+       id 1WiPnt-0004pf-2D; Thu, 08 May 2014 08:00:09 -0700\r
+From: Charles Celerier <cceleri@cs.stanford.edu>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/5] configure,\r
+       test: Added variables for paths to true and false.\r
+In-Reply-To: <87fvkkv4bc.fsf@maritornes.cs.unb.ca>\r
+References: <1399395748-44920-1-git-send-email-cceleri@cs.stanford.edu>\r
+       <1399395748-44920-2-git-send-email-cceleri@cs.stanford.edu>\r
+       <1399395748-44920-3-git-send-email-cceleri@cs.stanford.edu>\r
+       <87fvkkv4bc.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.18~rc0+32~gd5092c2 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-apple-darwin13.1.0)\r
+Date: Thu, 08 May 2014 11:00:07 -0400\r
+Message-ID: <m238gkpb7s.fsf@jane.lan>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-Scan-Signature: 6214ac49f2cb083a0c8190805312a710\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 08 May 2014 15:00:20 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+\r
+David Bremner <david@tethera.net> writes:\r
+\r
+> Charles Celerier <cceleri@cs.stanford.edu> writes:\r
+>\r
+>> The path to true may not be the same on all platforms (e.g. on Mac OS X\r
+>> it is /usr/bin/true), so the hard-coded path of /bin/true is not\r
+>> portable. This is resolved by adding a step to the configure script to\r
+>> locate the path of true and to use the TRUE variable wherever /bin/true\r
+>> was needed. The same was done for false.\r
+>\r
+> Does this really need a configure script variable? It seems like\r
+> overkill.\r
+\r
+I will be the first too admit that I do not know much about configure\r
+scripts, but adding a TRUE variable seemed straightforward. The problem\r
+is that you want to make softlinks for test/have-man and\r
+test/have-compact for how they are used in tests T010-help-test and\r
+T020-compact; making softlinks requires full paths. You could use\r
+`$(which true)` in test/Makefile.local, but I felt the code repetition\r
+there was unecessary since you could just create a TRUE variable in the\r
+configure script. An alternative is to change the tests so that the\r
+location of true (and false) is no longer an issue.\r
+\r
+chuck\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG/MacGPG2 v2.0.22 (Darwin)\r
+\r
+iQEcBAEBAgAGBQJTa5v3AAoJEOjk698fDjuASPEH/jBF3OMlZD5VHprNSm0J1Wfv\r
+qqnGPHPNTaDl2MRFY7EhPJ5rtuava3IEFP1iQLTeEvqwLYmQmYk/2xZj+Z7DnCX/\r
+C9B4QCT76j1Pq2I1N4x7cBvlSQvJZzPchUeQrMu8pV5kib9Zvrppdm/WHUkZeJPJ\r
+u+juPfbW/lsntcWEGPt35yW3LyH0VH5fnuTBdbau6K+cRaKxVelBKIDN6kot1CBQ\r
+lI9Hjm3E5m0IJSAAEzW2aAKMb+8J2dklsJwgohTl42eHlU/cVcShOp/wNhF2vJyM\r
+4cZeJEccigiLXEpmwpV4zBmDHfW/jWTN1zDOhi+HG0x6IA/Ku06u6WpyWMB7rGc=\r
+=CZ4Q\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r