--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 8FF5F431FD4\r
+ for <notmuch@notmuchmail.org>; Sun, 17 Nov 2013 12:41:47 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id SbPtB3-+cL4K for <notmuch@notmuchmail.org>;\r
+ Sun, 17 Nov 2013 12:41:40 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id E99AD431FAF\r
+ for <notmuch@notmuchmail.org>; Sun, 17 Nov 2013 12:41:39 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Vi99l-00030w-0D; Sun, 17 Nov 2013 20:41:21 +0000\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Vi99k-00035J-LO; Sun, 17 Nov 2013 20:41:20 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>,\r
+ Jameson Graef Rollins <jrollins@finestructure.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: do not put quoted reply in primary selection\r
+In-Reply-To: <m2eh6e7r2n.fsf@guru.guru-group.fi>\r
+References: <1384689849-9388-1-git-send-email-markwalters1009@gmail.com>\r
+ <87siuu95uy.fsf@servo.finestructure.net>\r
+ <m2eh6e7r2n.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 17 Nov 2013 20:41:19 +0000\r
+Message-ID: <878uwmvk0g.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-Geographic: According to ripencc,\r
+ this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 116b825651404d31647c9062f25b1151 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored 0.0 points. Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 17 Nov 2013 20:41:47 -0000\r
+\r
+\r
+On Sun, 17 Nov 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> On Sun, Nov 17 2013, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+>\r
+>> On Sun, Nov 17 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+>>> In current emacs (24.3) select-active-regions is set to t by\r
+>>> default. The reply insertion code sets the region to the quoted\r
+>>> message to make it easy to delete (kill-region or C-w). These two\r
+>>> things combine to put the quoted message in the primary selection.\r
+>>>\r
+>>> This is not what the user wanted and is a privacy risk (accidental\r
+>>> pasting of the quoted message). We can avoid some of the problems\r
+>>> by let-binding select-active-regions to nil. This fixes if the\r
+>>> primary selection was previously in a non-emacs window but not if\r
+>>> it was in an emacs window. To avoid the problem in the latter case\r
+>>> we deactivate mark.\r
+>>>\r
+>>> One key test (which fails under many simpler "fixes") is: open emacs\r
+>>> 24.3 with notmuch, open 2 windows (viewing different notmuch buffers),\r
+>>> highlight some text in one, and then reply to a message in the\r
+>>> other. In many of my earlier attempts to fix this big this test fails.\r
+>>\r
+>> I'm very happy to report that I reply to this message with an unpolluted\r
+>> paste buffer! Kudos Mark!\r
+>>\r
+>>> Anyway, this is the best I can manage!\r
+>>\r
+>> Too modest for such an achievement.\r
+>>\r
+>> +10\r
+>\r
+> This works for me too (and tests pass). \r
+\r
+That's great.\r
+\r
+> I don't see how this could break thinks, So I think this is important\r
+> enough th be included in 0.17 \r
+\r
+\r
+I think the only thing that could break is the ability to cut the quoted\r
+message with kill-region/ctrl-w. That is probably minor enough that we\r
+do not need to worry too much.\r
+\r
+Best wishes\r
+\r
+Mark\r
projects / notmuch-archives.git / commitdiff