--- /dev/null
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 65A0E431FC7\r
+ for <notmuch@notmuchmail.org>; Mon, 29 Sep 2014 09:05:27 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id PCmNDRzGIVxx for <notmuch@notmuchmail.org>;\r
+ Mon, 29 Sep 2014 09:05:19 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by olra.theworths.org (Postfix) with ESMTP id A0ABD431FCF\r
+ for <notmuch@notmuchmail.org>; Mon, 29 Sep 2014 09:05:18 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id E39F5100063;\r
+ Mon, 29 Sep 2014 19:04:59 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/5] cli: Refactor option passing in the search command\r
+In-Reply-To: <87k34rtoi2.fsf@steelpick.2x.cz>\r
+References: <1411378679-7307-1-git-send-email-sojkam1@fel.cvut.cz>\r
+ <1411378679-7307-2-git-send-email-sojkam1@fel.cvut.cz>\r
+ <m27g0rpl6x.fsf@guru.guru-group.fi>\r
+ <87k34rtoi2.fsf@steelpick.2x.cz>\r
+User-Agent: Notmuch/0.18.1+119~g5d90feb (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 29 Sep 2014 19:04:59 +0300\r
+Message-ID: <m27g0m1kgk.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 29 Sep 2014 16:05:27 -0000\r
+\r
+On Thu, Sep 25 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+\r
+> On Thu, Sep 25 2014, Tomi Ollila wrote:\r
+>> On Mon, Sep 22 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+>>\r
+>>> Many functions that implement the search command need to access command\r
+>>> line options. Instead of passing each option in a separate variable, put\r
+>>> them in a structure and pass only this structure.\r
+>>\r
+>> This patch looks good to me.\r
+>\r
+> Thanks for the review.\r
+>\r
+>> Although the test and the implementation in the next patches look OK, I'd\r
+>> prefer the FLAG implementation Jani suggested earlier. IMO now that I\r
+>> compare these two it looks cleaner and simpler...\r
+>\r
+> The question is which kind of simplicity you have in mind. I think that\r
+> my version is simpler to type (less keystrokes). But if others have\r
+> different opinion, I don't mind.\r
+\r
+Less keystrokes for sure -- but these interfaces are usually accessed\r
+programmatically... :D\r
+\r
+>>\r
+>> Tomi\r
+>>\r
+>> (*) IMO the default unique (when requested) would be exact case-sensitive\r
+>> match of full name & address \r
+>\r
+> Why do you think that case-sensitive address matching should be the\r
+> default? In theory local-part can be case sensitive, but I've never seen\r
+> that in reality. So this default would only be useful if you want to\r
+> research how people type your email address :)\r
+\r
+Well, in short, I think the lowest level of uniqueness should be simple\r
+string match, and this should at least be available if not default --\r
+to the extent gmime provides (maybe that is this way in your patch...),\r
+\r
+...and therefore I'd like to have this address output solved first, then\r
+we can experiment with the outputs provided and have better-educated\r
+comments on this issue...\r
+\r
+>> parts (phrase, address & comment); \r
+>\r
+> What do you mean by phrase and comment? Address syntax is defined by\r
+> http://tools.ietf.org/html/rfc5322#section-3.4.1.\r
+\r
+in \r
+\r
+"Foo Bar" (company/city) foo.bar@example.org\r
+\r
+and\r
+\r
+"Foo Bar" foo.bar@example.org (company/city) \r
+\r
+Phrase would be "Foo Bar"\r
+Address foo.bar@example.org\r
+and comment (company/city)\r
+\r
+As a side note, nottoomuch-addresses does some heuristics there, and think\r
+the 2 options above are equal (as "Phrase" (comment) address) -- which\r
+might the same InternetAddressMailbox provides :O\r
+\r
+Also, it seems that nottoomuch-addresses lowercases 'address' for\r
+comparison and storage ... I am not entirely sure whether I should provide\r
+options to disable these heuristics -- if someone asks for the feature\r
+then I probably will do :D\r
+\r
+>> then (a subset of possible) options could be:\r
+>> +) case-insensitive (first match taken (or last match?) -- option?)\r
+>> +) unique email addresses (take phrase/comment from first/last?)\r
+>> -- or use first that has something additional to plain address\r
+>> -- or use last that has something additional to plain address\r
+>\r
+> Yes, there is a lot of possible options. I don't think that notmuch has\r
+> to support all of them. If people need something special like "use last\r
+> that has something additional to plain address", they can always do\r
+> --unique=none and do their own post-processing.\r
+\r
+Ok, but something (we can further bikeshed with) needs to be selected :D\r
+\r
+>\r
+> -Michal\r
+\r
+Tomi\r
projects / notmuch-archives.git / commitdiff