Re: [PATCH 1/5] cli: Refactor option passing in the search command

diff --git a/72/4c52c28d271d2a141dd361fd51d9b59681dac2 b/72/4c52c28d271d2a141dd361fd51d9b59681dac2
new file mode 100644 (file)
index 0000000..14627a9
--- /dev/null
+++ b/72/4c52c28d271d2a141dd361fd51d9b59681dac2
@@ -0,0 +1,90 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5EE19431FB6\r
+       for <notmuch@notmuchmail.org>; Thu, 25 Sep 2014 12:14:14 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 30aYcDaDyjkE for <notmuch@notmuchmail.org>;\r
+       Thu, 25 Sep 2014 12:14:09 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id BF6AB431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 25 Sep 2014 12:14:09 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 68279100033;\r
+       Thu, 25 Sep 2014 22:13:58 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/5] cli: Refactor option passing in the search command\r
+In-Reply-To: <1411378679-7307-2-git-send-email-sojkam1@fel.cvut.cz>\r
+References: <1411378679-7307-1-git-send-email-sojkam1@fel.cvut.cz>\r
+       <1411378679-7307-2-git-send-email-sojkam1@fel.cvut.cz>\r
+User-Agent: Notmuch/0.18.1+97~g6c845ef (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 25 Sep 2014 22:13:58 +0300\r
+Message-ID: <m27g0rpl6x.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 25 Sep 2014 19:14:14 -0000\r
+\r
+On Mon, Sep 22 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+\r
+> Many functions that implement the search command need to access command\r
+> line options. Instead of passing each option in a separate variable, put\r
+> them in a structure and pass only this structure.\r
+\r
+This patch looks good to me. \r
+\r
+Although the test and the implementation in the next patches look OK, I'd\r
+prefer the FLAG implementation Jani suggested earlier. IMO now that I\r
+compare these two it looks cleaner and simpler...\r
+\r
+I.e. I'd prefer notmuch search --output=sender --output=recipients ...\r
+(same output regardless the order these options given).\r
+\r
+I'd postpone the unique handling to a bit later phase; there are quite a\r
+few options how to do that (*)\r
+\r
+\r
+Tomi\r
+\r
+(*) IMO the default unique (when requested) would be exact case-sensitive\r
+match of full name & address parts (phrase, address & comment); then\r
+(a subset of possible) options could be: \r
+   +) case-insensitive (first match taken (or last match?) -- option?)\r
+   +) unique email addresses (take phrase/comment from first/last?)\r
+      --  or use first that has something additional to plain address\r
+      --  or use last  that has something additional to plain address\r
+\r
+\r
+> This will become handy in the following patches.\r
+> ---\r
+>  notmuch-search.c | 122 ++++++++++++++++++++++++++++---------------------------\r
+>  1 file changed, 62 insertions(+), 60 deletions(-)\r
+>\r
+> diff --git a/notmuch-search.c b/notmuch-search.c\r
+> index bc9be45..5ac2a26 100644\r
+> --- a/notmuch-search.c\r
+> +++ b/notmuch-search.c\r