Re: [PATCH] add has: query prefix to search for specific properties

diff --git a/08/54d5888a32f3d86414fe39564ae7d2ebf6d534 b/08/54d5888a32f3d86414fe39564ae7d2ebf6d534
new file mode 100644 (file)
index 0000000..838ab1f
--- /dev/null
+++ b/08/54d5888a32f3d86414fe39564ae7d2ebf6d534
@@ -0,0 +1,88 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 258316DE0140\r
+ for <notmuch@notmuchmail.org>; Sat, 16 Jul 2016 17:40:06 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.011\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.011 tagged_above=-999 required=5 tests=[AWL=0.000,\r
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id KzNxP1zlrPvH for <notmuch@notmuchmail.org>;\r
+ Sat, 16 Jul 2016 17:39:57 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id C5EDF6DE0130\r
+ for <notmuch@notmuchmail.org>; Sat, 16 Jul 2016 17:39:57 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1bOa81-0006MO-MV; Sat, 16 Jul 2016 20:40:17 -0400\r
+Received: (nullmailer pid 25866 invoked by uid 1000);\r
+ Sun, 17 Jul 2016 00:39:53 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH] add has: query prefix to search for specific properties\r
+In-Reply-To: <1467969336-7605-1-git-send-email-dkg@fifthhorseman.net>\r
+References: <1465779955-5539-9-git-send-email-david@tethera.net>\r
+ <1467969336-7605-1-git-send-email-dkg@fifthhorseman.net>\r
+User-Agent: Notmuch/0.22+28~gb9bf3f4 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 16 Jul 2016 21:39:53 -0300\r
+Message-ID: <87ziphxfl2.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 17 Jul 2016 00:40:06 -0000\r
+\r
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+\r
+> We want to be able to query the properties directly, like:\r
+>\r
+>    notmuch count has:foo=bar\r
+>\r
+> which should return a count of messages where the property with key\r
+> "foo" has value equal to "bar".\r
+>\r
+> This patch could be improved:\r
+>\r
+> If no = sign is present (e.g. "has:foo"), it'd be nice to just match\r
+>  on every message that has property "foo", regardless of value.\r
+\r
+At the moment I can't think of a nice easy way to do this.  It could do\r
+something like that proposed for "tag:*", namely expand it internally\r
+into an or query, by traversing the\r
+db->allterms_begin("XPROPERTY"). \r
+\r
+> It would also be good to include some tests.\r
+\r
+and update notmuch-search-terms(7) ?\r
+\r
+>   *  TIMESTAMP:      The time_t value corresponding to the message's\r
+> @@ -260,6 +263,7 @@ static prefix_t BOOLEAN_PREFIX_EXTERNAL[] = {\r
+>      { "is",                 "K" },\r
+>      { "id",                 "Q" },\r
+>      { "path",                       "P" },\r
+> +    { "has",                        "XPROPERTY" },\r
+>      /*\r
+>       * Without the ":", since this is a multi-letter prefix, Xapian\r
+>       * will add a colon itself if the first letter of the path is\r
+\r
+Do we want to have the same prefix listed in BOOLEAN_PREFIX_INTERNAL and\r
+BOOLEAN_PREFIX_EXTERNAL? this seems quite fragile. If we don't though,\r
+we have to use the same prefix name for queries as in the code (which is\r
+already sprinkled with _find_prefix ("property") ).\r