Re: [PATCH] cli: bail out and propagate tagging errors in notmuch tag

diff --git a/fe/213986ab08e72bbf7eac34ec8c4f08f694c376 b/fe/213986ab08e72bbf7eac34ec8c4f08f694c376
new file mode 100644 (file)
index 0000000..22a11f3
--- /dev/null
+++ b/fe/213986ab08e72bbf7eac34ec8c4f08f694c376
@@ -0,0 +1,66 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id DADE4431FB6\r
+       for <notmuch@notmuchmail.org>; Wed,  9 Jan 2013 19:14:20 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id RBZRzmUdXb83 for <notmuch@notmuchmail.org>;\r
+       Wed,  9 Jan 2013 19:14:20 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 439E4431FAF\r
+       for <notmuch@notmuchmail.org>; Wed,  9 Jan 2013 19:14:20 -0800 (PST)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1Tt8am-00033v-9G; Wed, 09 Jan 2013 23:14:16 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1Tt8ag-0006ix-If; Wed, 09 Jan 2013 23:14:02 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] cli: bail out and propagate tagging errors in notmuch tag\r
+In-Reply-To: <1357681314-29384-1-git-send-email-jani@nikula.org>\r
+References: <1357681314-29384-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 09 Jan 2013 23:14:02 -0400\r
+Message-ID: <87fw29wwzp.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 10 Jan 2013 03:14:21 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+> +    if (ret)\r
+> +        break;\r
+\r
+I amended this to (ret != NOTMUCH_STATUS_SUCCESS) \r
+\r
+There are a few different families of status codes flying around here,\r
+and I liked the extra documentation.\r
+\r
+d\r