Re: [PATCH v3 2/3] emacs: Rename incremental JSON internal variables.

diff --git a/81/5192d23058dd416057441781b0b3ca763bcbbe b/81/5192d23058dd416057441781b0b3ca763bcbbe
new file mode 100644 (file)
index 0000000..e88e15c
--- /dev/null
+++ b/81/5192d23058dd416057441781b0b3ca763bcbbe
@@ -0,0 +1,111 @@
+Return-Path: <ethan.glasser.camp@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 85728431FAF\r
+       for <notmuch@notmuchmail.org>; Tue, 23 Oct 2012 18:37:00 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 6e6t--ZmSLPA for <notmuch@notmuchmail.org>;\r
+       Tue, 23 Oct 2012 18:36:59 -0700 (PDT)\r
+Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com\r
+       [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 33F1D431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 23 Oct 2012 18:36:59 -0700 (PDT)\r
+Received: by mail-vb0-f53.google.com with SMTP id fc21so5028vbb.26\r
+       for <notmuch@notmuchmail.org>; Tue, 23 Oct 2012 18:36:57 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=i6shZUBWKoWPxYBb7CsVdQ9BSxSeTWY69sMo2G3cv9g=;\r
+       b=aeoLJzYfk2X6PC8XhbBVen7hH8ApCP5AG2fUv5SRvMWoHmUbtUR5C/UPrnDJ16Vkir\r
+       cAXfg9ZUHWpifga2VO1jmq7tuxH/BsImSyfr+5a6xJVjppacXVC2RRlX+mmrN10TJ+Jz\r
+       m6TbFyh6aWbJxN2ueVVPtnfquaJkUjqgDXJxD/RQu5LqHzpsp4oe1O9XUCGx/vjhVynp\r
+       6EzKbhNJH8MvRSalcAdL5SPeEYvilQxrfMWn4kAxg41o/OgsogPvedCsTigld5RZm5g0\r
+       dNY3gkSKkMWkURBzgQB1bW8dBozAA8k9guvqSG0gWXYBzeWF+3v1VyHjZgI3WXKriIhW\r
+       Sq0g==\r
+Received: by 10.58.137.229 with SMTP id ql5mr26724968veb.11.1351042617357;\r
+       Tue, 23 Oct 2012 18:36:57 -0700 (PDT)\r
+Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])\r
+       by mx.google.com with ESMTPS id q7sm7615899vdw.22.2012.10.23.18.36.55\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Tue, 23 Oct 2012 18:36:56 -0700 (PDT)\r
+From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 2/3] emacs: Rename incremental JSON internal variables.\r
+In-Reply-To: <1351037602-11157-3-git-send-email-markwalters1009@gmail.com>\r
+References: <1351037602-11157-1-git-send-email-markwalters1009@gmail.com>\r
+       <1351037602-11157-3-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 23 Oct 2012 21:36:52 -0400\r
+Message-ID: <876260k5vv.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 24 Oct 2012 01:37:00 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> This patch just renames the internal variables for the JSON parser now\r
+> it is no longer specific to search mode. It also fixes up the white\r
+> space after the previous patch. There should be no functional changes.\r
+\r
+This series looks very good to me. I still have a couple of quibbles that I wouldn't say\r
+should hold the series up. First, your commit messages have periods at\r
+the end of the first line. I think it is considered good practice that\r
+they not (see, e.g.,\r
+http://blogs.gnome.org/danni/2011/10/25/a-guide-to-writing-git-commit-messages/ ).\r
+\r
+> -(defvar notmuch-search-process-state nil\r
+> -  "Parsing state of the search process filter.")\r
+> +(defvar notmuch-json-state nil\r
+> +  "State of the internal JSON parser.")\r
+\r
+How about,\r
+\r
+"State of the shared JSON parser.\r
+\r
+This variable will be a symbol, corresponding to the state of the JSON\r
+parser's state machine. 'begin means we haven't yet entered a JSON\r
+list. 'result means we are ready to parse a JSON object. 'end means we\r
+have exited the JSON list."\r
+\r
+(Or whatever the correct meanings of the parser's states are...)\r
+\r
+> -(defvar notmuch-search-json-parser nil\r
+> -  "Incremental JSON parser for the search process filter.")\r
+> +(defvar notmuch-json-parser nil\r
+> +  "Internal Incremental JSON parser Object.")\r
+\r
+How about,\r
+\r
+"Shared notmuch JSON parser object, as created by\r
+(notmuch-json-create-parser).\r
+\r
+Any notmuch code can parse part of a JSON list object by setting this\r
+variable to their JSON parser and calling\r
+notmuch-json-parse-partial-list (which see)."\r
+\r
+(Or whatever one is supposed to do with the parser object...)\r
+\r
+Ethan\r