Re: [PATCH v2 3/7] emacs: tag: add customize for deleted/added tag formats

diff --git a/86/25c9a8525e03c37e2f3ff76b7b527b7b62ece9 b/86/25c9a8525e03c37e2f3ff76b7b527b7b62ece9
new file mode 100644 (file)
index 0000000..7a9d742
--- /dev/null
+++ b/86/25c9a8525e03c37e2f3ff76b7b527b7b62ece9
@@ -0,0 +1,147 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 83762431FBD\r
+       for <notmuch@notmuchmail.org>; Mon, 10 Mar 2014 19:37:23 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 9lwvAK3KhCoO for <notmuch@notmuchmail.org>;\r
+       Mon, 10 Mar 2014 19:37:18 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-8.mit.edu (dmz-mailsec-scanner-8.mit.edu\r
+       [18.7.68.37])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 5E72E431FBC\r
+       for <notmuch@notmuchmail.org>; Mon, 10 Mar 2014 19:37:18 -0700 (PDT)\r
+X-AuditID: 12074425-f79906d000000cf9-6b-531e76dd9f00\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+       (using TLS with cipher AES256-SHA (256/256 bits))\r
+       (Client did not present a certificate)\r
+       by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 26.51.03321.DD67E135; Mon, 10 Mar 2014 22:37:17 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+       by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id s2B2bGuX005856; \r
+       Mon, 10 Mar 2014 22:37:17 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s2B2bFwE018144\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+       Mon, 10 Mar 2014 22:37:16 -0400\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1WNCZ8-0008SN-UJ; Mon, 10 Mar 2014 22:37:14 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 3/7] emacs: tag: add customize for deleted/added tag\r
+       formats\r
+In-Reply-To: <1392841212-8494-4-git-send-email-markwalters1009@gmail.com>\r
+References: <1392841212-8494-1-git-send-email-markwalters1009@gmail.com>\r
+       <1392841212-8494-4-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.17~rc2+14~g06f47e0 (http://notmuchmail.org) Emacs/23.4.1\r
+       (i486-pc-linux-gnu)\r
+Date: Mon, 10 Mar 2014 22:37:14 -0400\r
+Message-ID: <8761nl31gl.fsf@awakening.csail.mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFrrPIsWRmVeSWpSXmKPExsUixCmqrXu3TC7Y4PxFJYvVc3ksrt+cyezA\r
+       5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZdxb85Ol4L1wxYeTrA2MswW6GDk5JARMJM53\r
+       fGGBsMUkLtxbz9bFyMUhJDCbSeLm1JUsEM5GRonT59+wgVQJCZxmkjiwQgwisYRRYtn7E2AJ\r
+       NgENiW37lzOC2CICrhJPv31mBrGFBYIltu+9xw5icwp4SrRM6IWa2soocXHCD7BmUYEkidNT\r
+       f7N2MXJwsAioSvy/4AwS5gU6r+15JyuELShxcuYTsFOZBbQkbvx7yTSBUWAWktQsJKkFjEyr\r
+       GGVTcqt0cxMzc4pTk3WLkxPz8lKLdC30cjNL9FJTSjcxgsKR3UV1B+OEQ0qHGAU4GJV4eAN8\r
+       5YKFWBPLiitzDzFKcjApifLWlgCF+JLyUyozEosz4otKc1KLDzFKcDArifCetgDK8aYkVlal\r
+       FuXDpKQ5WJTEefvOSgQLCaQnlqRmp6YWpBbBZGU4OJQkeMVAhgoWpaanVqRl5pQgpJk4OEGG\r
+       8wANZy0DGV5ckJhbnJkOkT/FqCglzltUCpQQAElklObB9cLSxStGcaBXhHllQNp5gKkGrvsV\r
+       0GAmoMHNx6VABpckIqSkGhg1U0vlV3wM7P9RcZjPMuLM6Qvy1Q6H6laLW0hWPinqOarEXP6a\r
+       MfLKdoWDi8+8uuXondu4sHPv7HCRZxqiJ6y+TuE+xOywSObE4doZ/bO2Kp3ZzHiSq1F4p39s\r
+       bQCjokn2GTvBlTMlny9SWyD6KNrdkENluVso45dTC/zufZ3mkW67ZK2xwxclluKMREMt5qLi\r
+       RACHOsRe8gIAAA==\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 11 Mar 2014 02:37:23 -0000\r
+\r
+On Wed, 19 Feb 2014, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> Add customize options for deleted/added tag formats.  These are not\r
+> used yet but will be later in the series.\r
+> ---\r
+>  emacs/notmuch-tag.el |   31 +++++++++++++++++++++++++++++++\r
+>  1 files changed, 31 insertions(+), 0 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el\r
+> index 878aaf7..064fbdb 100644\r
+> --- a/emacs/notmuch-tag.el\r
+> +++ b/emacs/notmuch-tag.el\r
+> @@ -101,6 +101,37 @@ with images."\r
+>    :group 'notmuch-show\r
+>    :type 'notmuch-tag-format-type)\r
+>  \r
+> +(defcustom notmuch-tag-deleted-formats\r
+> +  '((".*" (propertize tag 'face\r
+\r
+It occurs to me that `propertize' is problematic here, since it replaces\r
+the face property of the tag wholesale.  If we really want this to apply\r
+in addition to a face added by notmuch-tag-formats, I don't think\r
+there's any way to massage things so that `propertize' works (short of\r
+horrible hackery).  `notmuch-combine-face-text-property-string' does\r
+exactly what we need here, but maybe needs a shorter name?\r
+`notmuch-apply-face'?  Or maybe there's some solution I'm not thinking\r
+of?\r
+\r
+> +                  (if (display-supports-face-attributes-p '(:strike-through "red"))\r
+> +                      '(:strike-through "red")\r
+> +                    '(:inverse-video t)))))\r
+> +  "Custom formats for tags when deleted.\r
+> +\r
+> +For deleted tags the formats in `notmuch-tag-formats` are applied\r
+> +first and then these formats are applied on top.\r
+> +\r
+> +By default this shows deleted tags with strike-through in red,\r
+> +unless strike-through is not available (e.g., emacs is running in\r
+> +a terminal) in which case it uses inverse video. To hide deleted\r
+> +tags completely set this to\r
+> +  '((\"\" nil))\r
+> +\r
+> +See `notmuch-tag-formats' for full documentation."\r
+> +  :group 'notmuch-show\r
+> +  :type 'notmuch-tag-format-type)\r
+> +\r
+> +(defcustom notmuch-tag-added-formats\r
+> +  '((".*" (propertize tag 'face '(:underline "green"))))\r
+> +  "Custom formats for tags when added.\r
+> +\r
+> +For added tags the formats in `notmuch-tag-formats` are applied\r
+> +first and then these formats are applied on top.\r
+> +\r
+> +See `notmuch-tag-formats' for full documentation."\r
+> +  :group 'notmuch-show\r
+> +  :type 'notmuch-tag-format-type)\r
+> +\r
+>  (defun notmuch-tag-format-image-data (tag data)\r
+>    "Replace TAG with image DATA, if available.\r
+>  \r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r