Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..."

diff --git a/36/8574a766a279962cc49bb6006c40eed41a6bcb b/36/8574a766a279962cc49bb6006c40eed41a6bcb
new file mode 100644 (file)
index 0000000..13e1fc3
--- /dev/null
+++ b/36/8574a766a279962cc49bb6006c40eed41a6bcb
@@ -0,0 +1,87 @@
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 34524429E4A\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Jan 2012 01:20:35 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id P09mmsYNplJ0 for <notmuch@notmuchmail.org>;\r
+       Sat, 14 Jan 2012 01:20:34 -0800 (PST)\r
+Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com\r
+       [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 837C5429E49\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Jan 2012 01:20:34 -0800 (PST)\r
+Received: by wibhr12 with SMTP id hr12so1051405wib.26\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Jan 2012 01:20:33 -0800 (PST)\r
+Received: by 10.180.24.105 with SMTP id t9mr7327837wif.19.1326532833284;\r
+       Sat, 14 Jan 2012 01:20:33 -0800 (PST)\r
+Received: from localhost ([109.131.75.86])\r
+       by mx.google.com with ESMTPS id fq7sm14225669wbb.1.2012.01.14.01.20.32\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sat, 14 Jan 2012 01:20:32 -0800 (PST)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: David Edmondson <dme@dme.org>, Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with\r
+       "(unless ..."\r
+In-Reply-To: <cund3an7fk6.fsf@hotblack-desiato.hh.sledj.net>\r
+References: <87vcogketu.fsf@praet.org>\r
+       <1326389586-21683-1-git-send-email-pieter@praet.org>\r
+       <cund3an7fk6.fsf@hotblack-desiato.hh.sledj.net>\r
+User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+Date: Sat, 14 Jan 2012 10:18:46 +0100\r
+Message-ID: <87hazyprpl.fsf@praet.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 14 Jan 2012 09:20:35 -0000\r
+\r
+On Fri, 13 Jan 2012 16:06:17 +0000, David Edmondson <dme@dme.org> wrote:\r
+> On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> > Less code, same results, without sacrificing readability.\r
+> \r
+> Does this change correctly re-indent the line following the if/unless?\r
+\r
+It does...\r
+\r
+Or so I thought... I appear to have forgotten to correct the indentation\r
+@ `notmuch-hello-insert-tags'.\r
+\r
+\r
+Unfortunately git doesn't provide a way to diff the whitespace itself;\r
+  (eg. "git diff --word-diff=color --word-diff-regex='[ \t]*'")\r
+\r
+Setting "color.diff.whitespace" (and perhaps expanding the scope of\r
+"core.whitespace") only colorizes *erroneous* whitespace...\r
+\r
+\r
+Does this really warrant a v2, or might we simply leave it as yet\r
+another victim for Tomi's uncrustify-for-elisp [1] ?\r
+\r
+\r
+Peace\r
+\r
+-- \r
+Pieter\r
+\r
+[1] id:"yf639bkexs3.fsf@taco2.nixu.fi"\r