[PATCH 2/4] configure: SC2059: Don't use variables in the printf format string.

diff --git a/51/826acdca520689d86bcd21d22d19bc4b450307 b/51/826acdca520689d86bcd21d22d19bc4b450307
new file mode 100644 (file)
index 0000000..dbe2c44
--- /dev/null
+++ b/51/826acdca520689d86bcd21d22d19bc4b450307
@@ -0,0 +1,142 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 562A46DE034D\r
+ for <notmuch@notmuchmail.org>; Wed, 13 Apr 2016 11:34:25 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References"\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.562\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.562 tagged_above=-999 required=5 tests=[AWL=0.158,\r
+  DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\r
+ RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 637gw7bnmzmi for <notmuch@notmuchmail.org>;\r
+ Wed, 13 Apr 2016 11:34:17 -0700 (PDT)\r
+Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com\r
+ [74.125.82.67]) by arlo.cworth.org (Postfix) with ESMTPS id 3833D6DE0159 for\r
+ <notmuch@notmuchmail.org>; Wed, 13 Apr 2016 11:34:08 -0700 (PDT)\r
+Received: by mail-wm0-f67.google.com with SMTP id a140so16473382wma.2\r
+ for <notmuch@notmuchmail.org>; Wed, 13 Apr 2016 11:34:08 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=nikula-org.20150623.gappssmtp.com; s=20150623;\r
+ h=from:to:cc:subject:date:message-id:in-reply-to:references\r
+ :in-reply-to:references;\r
+ bh=ZQtMu6syqmdLFdv5757KBmnTFlOVdvvf836rTLryWIM=;\r
+ b=LfXOVA3169+KoQg0p5ewsembQXtQjQ4yZJGHRR0YVENwftn7g6yggP+3hvSKQW2PFg\r
+ HyD5ViyS8BfqvQB8IGbEFhXJrchkDk+2Mm4ktlwyYXOqMGT2INebPwOhHJV9/DXQG0f6\r
+ pQQ3dEEacPermzqCsUo6hbJGRJ573XLBHJ2K7hozGazFS7NYD90ufNjOmNvT2TkX0MB0\r
+ DXIzeKJFps6gTPzbzlC0tVlVxz/pxIkY2jUTQBjU/ahcqX6Qqz7miOmYc0A1FCDF/hrn\r
+ KjdEL6BgtWtDdu5tv6KkQNrMykX+0CVNW8n/eQ4Ym9Oq5ro/hvuoHBtzpkHUo0z9g1Ll\r
+ iH6g==\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\r
+ :references:in-reply-to:references;\r
+ bh=ZQtMu6syqmdLFdv5757KBmnTFlOVdvvf836rTLryWIM=;\r
+ b=FAKstrF29HMv9mtvlRCkaka+YLF9nWLCFMXzXBnOYyiQ19wfCsKudqm2F8F1cUrWPZ\r
+ AADteMLtusT+kuPi9ooG6IjK2DuO8CDei90f/geQR4I/ODHiKY0G32wtFtG7Bc1Au3D5\r
+ bvcDppYbQqm8Hw7FdP1KEuQFa2LY6lIh21eP/+64Q9ziVUXf2tNteoFnMsnwCDntOLiz\r
+ ggPZ2EhHD5SHcSiovDzUuw9dPET6VhKDwkw/NUK1804BIoFC/+2gdFLxIc6sOuK05WDZ\r
+ 7X57fVUKP1C2UVmFFGaoNNlzx0rRhzCPPgA2PfVd/xmh138QnLfHSYh/ZtCIwh1v6R9P\r
+ SBFg==\r
+X-Gm-Message-State:\r
+ AOPr4FWMpc69/ToEvw5wlTQLpH9Xt3kHfBBVEseOJuw7rGdOtI5iPgHERoe3JW60B0Xb2w==\r
+X-Received: by 10.28.172.132 with SMTP id v126mr12403703wme.28.1460572446845; \r
+ Wed, 13 Apr 2016 11:34:06 -0700 (PDT)\r
+Received: from localhost (mobile-access-bcee7f-102.dhcp.inet.fi.\r
+ [188.238.127.102])\r
+ by smtp.gmail.com with ESMTPSA id f186sm22317390wmf.24.2016.04.13.11.34.06\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Wed, 13 Apr 2016 11:34:06 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH 2/4] configure: SC2059: Don't use variables in the printf\r
+ format string.\r
+Date: Wed, 13 Apr 2016 21:32:47 +0300\r
+Message-Id:\r
+ <ce35b2aeb593fadf7cc22acfc32714a663141730.1460572142.git.jani@nikula.org>\r
+X-Mailer: git-send-email 2.1.4\r
+In-Reply-To: <cover.1460572142.git.jani@nikula.org>\r
+References: <cover.1460572142.git.jani@nikula.org>\r
+In-Reply-To: <cover.1460572142.git.jani@nikula.org>\r
+References: <cover.1460572142.git.jani@nikula.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 13 Apr 2016 18:34:25 -0000\r
+\r
+Fix shellcheck warnings. Use printf "..%s.." "$foo".\r
+---\r
+ configure | 12 ++++++------\r
+ 1 file changed, 6 insertions(+), 6 deletions(-)\r
+\r
+diff --git a/configure b/configure\r
+index 0c6cdb01bbe0..d4f56b905cce 100755\r
+--- a/configure\r
++++ b/configure\r
+@@ -387,7 +387,7 @@ EOF\r
+     else\r
+       default_xapian_backend=chert\r
+     fi\r
+-    printf "${default_xapian_backend}\n";\r
++    printf "%s\n" "${default_xapian_backend}";\r
+     rm -rf test.db _default_backend _default_backend.cc\r
+ fi\r
+ # we need to have a version >= 2.6.5 to avoid a crypto bug. We need\r
+@@ -461,7 +461,7 @@ for name in ${PYTHON} python python2 python3; do\r
+     if command -v $name > /dev/null; then\r
+       have_python=1\r
+       python=$name\r
+-      printf "Yes ($name).\n"\r
++      printf "Yes (%s).\n" "$name"\r
+       break\r
+     fi\r
+ done\r
+@@ -560,11 +560,11 @@ elif [ $uname = "OpenBSD" ] ; then\r
+     platform=OPENBSD\r
+     linker_resolves_library_dependencies=0\r
+ elif [ $uname = "Linux" ] || [ $uname = "GNU" ] ; then\r
+-    printf "$uname\n"\r
++    printf "%s\n" "$uname"\r
+     platform="$uname"\r
+     linker_resolves_library_dependencies=1\r
+ \r
+-    printf "Checking for $libdir_expanded in ldconfig... "\r
++    printf "Checking for %s in ldconfig... " "$libdir_expanded"\r
+     ldconfig_paths=$(/sbin/ldconfig -N -X -v 2>/dev/null | sed -n -e 's,^\(/.*\):\( (.*)\)\?$,\1,p')\r
+     # Separate ldconfig_paths only on newline (not on any potential\r
+     # embedded space characters in any filenames). Note, we use a\r
+@@ -815,7 +815,7 @@ for flag in -Wall -Wextra -Wwrite-strings; do\r
+       WARN_CXXFLAGS="${WARN_CXXFLAGS}${WARN_CXXFLAGS:+ }${flag}"\r
+     fi\r
+ done\r
+-printf "\n\t${WARN_CXXFLAGS}\n"\r
++printf "\n\t%s\n" "${WARN_CXXFLAGS}"\r
+ \r
+ WARN_CFLAGS="${WARN_CXXFLAGS}"\r
+ printf "Checking for available C compiler warning flags... "\r
+@@ -825,7 +825,7 @@ for flag in -Wmissing-declarations; do\r
+       WARN_CFLAGS="${WARN_CFLAGS}${WARN_CFLAGS:+ }${flag}"\r
+     fi\r
+ done\r
+-printf "\n\t${WARN_CFLAGS}\n"\r
++printf "\n\t%s\n" "${WARN_CFLAGS}"\r
+ \r
+ rm -f minimal minimal.c _libversion.c _libversion _libversion.sh\r
+ \r
+-- \r
+2.1.4\r
+\r