Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.

diff --git a/f4/0799b1a0db64f7b52c4fe6177230ef447d371a b/f4/0799b1a0db64f7b52c4fe6177230ef447d371a
new file mode 100644 (file)
index 0000000..97e7d15
--- /dev/null
+++ b/f4/0799b1a0db64f7b52c4fe6177230ef447d371a
@@ -0,0 +1,106 @@
+Return-Path: <cceleri@cs.stanford.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 26D77431FBF\r
+       for <notmuch@notmuchmail.org>; Thu,  8 May 2014 18:20:53 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id xEQz0ixZkZGd for <notmuch@notmuchmail.org>;\r
+       Thu,  8 May 2014 18:20:45 -0700 (PDT)\r
+Received: from smtp2.cs.Stanford.EDU (smtp2.cs.Stanford.EDU [171.64.64.26])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 813F5431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  8 May 2014 18:20:45 -0700 (PDT)\r
+Received: from chomsky.torservers.net ([77.247.181.162] helo=jane.lan)\r
+       by smtp2.cs.Stanford.EDU with esmtpsa (UNKNOWN:AES128-GCM-SHA256:128)\r
+       (Exim 4.80.1) (envelope-from <cceleri@cs.stanford.edu>)\r
+       id 1WiZUM-0000Zu-Px; Thu, 08 May 2014 18:20:39 -0700\r
+From: Charles Celerier <cceleri@cs.stanford.edu>\r
+To: David Bremner <david@tethera.net>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.\r
+In-Reply-To: <87a9arvs9b.fsf@maritornes.cs.unb.ca>\r
+References: <1399395748-44920-1-git-send-email-cceleri@cs.stanford.edu>\r
+       <1399434615-28425-1-git-send-email-cceleri@cs.stanford.edu>\r
+       <1399434615-28425-2-git-send-email-cceleri@cs.stanford.edu>\r
+       <87d2fov2qj.fsf@maritornes.cs.unb.ca> <m2zjisnwie.fsf@jane.lan>\r
+       <87a9arvs9b.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.18~rc0+32~gd5092c2 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-apple-darwin13.1.0)\r
+Date: Thu, 08 May 2014 21:20:27 -0400\r
+Message-ID: <m2iopfoihw.fsf@jane.lan>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-Scan-Signature: 127ff6e1eac6b45a32dc112250ed777d\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 09 May 2014 01:20:53 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+\r
+David Bremner <david@tethera.net> writes:\r
+\r
+> Charles Celerier <cceleri@cs.stanford.edu> writes:\r
+>\r
+>> Here is some of output of the matches made on the output of nm:\r
+>>\r
+>>     $ nm -g test/../lib/*.o | sed -n '/.*\s\+T\s\+_\(notmuch_.*\)/p'\r
+>>     00000000000028c0 T _notmuch_database_add_message\r
+>>     0000000000002280 T _notmuch_database_begin_atomic\r
+>>     0000000000001af0 T _notmuch_database_close\r
+>>     0000000000001de0 T _notmuch_database_compact\r
+>\r
+> With GNU nm, there is no leading _ in front of notmuch here, which is\r
+> what causes your version of the test to fail for me.\r
+\r
+What version of GNU nm are you using?\r
+\r
+    $ nm --version\r
+    GNU nm (GNU Binutils) 2.24\r
+    Copyright 2013 Free Software Foundation, Inc.\r
+    This program is free software; you may redistribute it under the terms of\r
+    the GNU General Public License version 3 or (at your option) any later version.\r
+    This program has absolutely no warranty.\r
+\r
+I'm not convinced the insertion of an underscore is nm's doing.\r
+\r
+At this point, I'm not sure how to create a better version of this\r
+patch. Are we renaming functions in notmuch-private.h? Should we stick\r
+with objdump or switch to using nm?\r
+\r
+chuck\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG/MacGPG2 v2.0.22 (Darwin)\r
+\r
+iQEcBAEBAgAGBQJTbC1cAAoJEOjk698fDjuAn0AH/ihbVGsZ60fHoO5ko3WXPnbq\r
+7hxRtjfAbXYhAy3P+mh4+QLHJQpCCd+jOUe0avXPvXotSZ3WehdqoGVSkdXufuX/\r
+TTNrWDaV2iKHnfQgbPY9qxmUnh7X/Ab2q67kq/2zYj0yubinz29HXznpadf3pV5X\r
+7UHhGTs7hX0bKt4i0oo6ZCaA4Xz5GwCQ//PBlAhbP+2ByzIsHeizo9qm3AL2eaDA\r
+xUKgagYyFINB3Zj2UHO0gD+qheYq7y1gdEdGdXJxoHPsxAQ80iepyLf1GLXGhSZk\r
+RVjEkk7fOqaYkjnB/NDJX+0XVrx8j5+p0+Wxbbiu1PFHywbOzEz6UCiAxWCAL+I=\r
+=RmRQ\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r