Re: [PATCH 1/3] emacs: Introduce `notmuch-call-notmuch-sexp'

diff --git a/5d/05fa42b293355d7d66190e8d834805e3d9b5b4 b/5d/05fa42b293355d7d66190e8d834805e3d9b5b4
new file mode 100644 (file)
index 0000000..33a5713
--- /dev/null
+++ b/5d/05fa42b293355d7d66190e8d834805e3d9b5b4
@@ -0,0 +1,101 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1CB08431FC2\r
+       for <notmuch@notmuchmail.org>; Mon, 24 Jun 2013 08:36:10 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id v5FVd7ADOzLf for <notmuch@notmuchmail.org>;\r
+       Mon, 24 Jun 2013 08:36:00 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id C2AC5431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 24 Jun 2013 08:35:59 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 79C39100094;\r
+       Mon, 24 Jun 2013 18:35:50 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/3] emacs: Introduce `notmuch-call-notmuch-sexp'\r
+In-Reply-To: <1372030999-1262-1-git-send-email-amdragon@mit.edu>\r
+References: <1372030999-1262-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.15.2+186~ga3c514a (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 24 Jun 2013 18:35:50 +0300\r
+Message-ID: <m2k3ljcyi1.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 24 Jun 2013 15:36:10 -0000\r
+\r
+On Mon, Jun 24 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> This is just like `notmuch-call-notmuch-json', but parses S-expression\r
+> output.  Note that, also like `notmuch-call-notmuch-json', this\r
+> doesn't consider trailing data to be an error, which may or may not be\r
+> what we want in the long run.\r
+> ---\r
+\r
+This series looks good (if not trivial), works in use and tests pass. +1\r
+\r
+Tomi\r
+\r
+\r
+>  emacs/notmuch-lib.el |   17 +++++++++++++++++\r
+>  1 file changed, 17 insertions(+)\r
+>\r
+> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el\r
+> index 534f217..36eacc1 100644\r
+> --- a/emacs/notmuch-lib.el\r
+> +++ b/emacs/notmuch-lib.el\r
+> @@ -484,6 +484,23 @@ an error."\r
+>            (json-read)))\r
+>      (delete-file err-file)))))\r
+>  \r
+> +(defun notmuch-call-notmuch-sexp (&rest args)\r
+> +  "Invoke `notmuch-command' with ARGS and return the parsed S-exp output.\r
+> +\r
+> +If notmuch exits with a non-zero status, this will pop up a\r
+> +buffer containing notmuch's output and signal an error."\r
+> +\r
+> +  (with-temp-buffer\r
+> +    (let ((err-file (make-temp-file "nmerr")))\r
+> +      (unwind-protect\r
+> +      (let ((status (apply #'call-process\r
+> +                           notmuch-command nil (list t err-file) nil args)))\r
+> +        (notmuch-check-exit-status status (cons notmuch-command args)\r
+> +                                   (buffer-string) err-file)\r
+> +        (goto-char (point-min))\r
+> +        (read (current-buffer)))\r
+> +    (delete-file err-file)))))\r
+> +\r
+>  (defun notmuch-start-notmuch (name buffer sentinel &rest args)\r
+>    "Start and return an asynchronous notmuch command.\r
+>  \r
+> -- \r
+> 1.7.10.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r