Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the...

diff --git a/c6/c9d1f17903a5b990ecb453b993bf427a9d7260 b/c6/c9d1f17903a5b990ecb453b993bf427a9d7260
new file mode 100644 (file)
index 0000000..88fe178
--- /dev/null
+++ b/c6/c9d1f17903a5b990ecb453b993bf427a9d7260
@@ -0,0 +1,108 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 16290431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 15 Apr 2012 10:33:27 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 9zyYtblCI+-0 for <notmuch@notmuchmail.org>;\r
+       Sun, 15 Apr 2012 10:33:26 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 571AC431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 15 Apr 2012 10:33:26 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 2C42E68055; Sun, 15 Apr 2012 20:33:22 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, David Edmondson <dme@dme.org>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/2] emacs: Don't move to the next thread unless the\r
+       cursor is at the end of the buffer.\r
+In-Reply-To: <87lilw6hnw.fsf@qmul.ac.uk>\r
+References: <1327996914-9644-1-git-send-email-dme@dme.org>\r
+       <1327996914-9644-3-git-send-email-dme@dme.org>\r
+       <87lilw6hnw.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.12+113~gde05574 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 15 Apr 2012 20:33:22 +0300\r
+Message-ID: <m2iph0sxwd.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 15 Apr 2012 17:33:27 -0000\r
+\r
+On Sun, Apr 15 2012, Mark Walters wrote:\r
+\r
+> On Tue, 31 Jan 2012, David Edmondson <dme@dme.org> wrote:\r
+>> When using the spacebar to scroll through a thread, hitting 'space'\r
+>> when the bottom of the last message is visible should take the cursor\r
+>> to the end of the buffer rather than immediately archiving the thread\r
+>> and moving to the next thread.\r
+>\r
+> Hi\r
+>\r
+> This patch looks good to me; (but if people prefer the current behaviour then\r
+> can we mark this notmuch::wontfix so it leaves the review queue)\r
+\r
+I would definitely like to see this patch applied. Less surprising\r
+as there is no indication we have reached the bottom of the buffer.\r
+\r
+> Best wishes\r
+>\r
+> Mark\r
+\r
+Tomi\r
+\r
+\r
+>\r
+>> ---\r
+>>  emacs/notmuch-show.el |    5 +++++\r
+>>  1 files changed, 5 insertions(+), 0 deletions(-)\r
+>>\r
+>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+>> index ec72ff8..3f54de0 100644\r
+>> --- a/emacs/notmuch-show.el\r
+>> +++ b/emacs/notmuch-show.el\r
+>> @@ -1319,6 +1319,11 @@ current window), advance to the next open message."\r
+>>        ;; This is not the last message - move to the next visible one.\r
+>>        (notmuch-show-next-open-message))\r
+>>  \r
+>> +     ((not (= (point) (point-max)))\r
+>> +      ;; This is the last message, but the cursor is not at the end of\r
+>> +      ;; the buffer. Move it there.\r
+>> +      (goto-char (point-max)))\r
+>> +\r
+>>       (t\r
+>>        ;; This is the last message - change the return value\r
+>>        (setq ret t)))\r
+>> -- \r
+>> 1.7.8.3\r
+>>\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r