Re: [Patch v2 0/3] emacs: allow show to colour based on tags and flags
authorAustin Clements <amdragon@MIT.EDU>
Sun, 29 Apr 2012 23:02:20 +0000 (19:02 +2000)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:46:49 +0000 (09:46 -0800)
9c/56068b28e74e47c469ba0720169fb72891b359 [new file with mode: 0644]

diff --git a/9c/56068b28e74e47c469ba0720169fb72891b359 b/9c/56068b28e74e47c469ba0720169fb72891b359
new file mode 100644 (file)
index 0000000..7b99393
--- /dev/null
@@ -0,0 +1,115 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id CD927431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Apr 2012 16:02:23 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 8cc8Zpq5LwYZ for <notmuch@notmuchmail.org>;\r
+       Sun, 29 Apr 2012 16:02:23 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU\r
+       [18.9.25.15])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3B0EE431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Apr 2012 16:02:23 -0700 (PDT)\r
+X-AuditID: 1209190f-b7f4f6d00000092b-31-4f9dc87ece4e\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+       by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 38.ED.02347.E78CD9F4; Sun, 29 Apr 2012 19:02:22 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q3TN2Mkr032629; \r
+       Sun, 29 Apr 2012 19:02:22 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q3TN2KPt021627\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Sun, 29 Apr 2012 19:02:21 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1SOd8G-00049m-Ny; Sun, 29 Apr 2012 19:02:20 -0400\r
+Date: Sun, 29 Apr 2012 19:02:20 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [Patch v2 0/3] emacs: allow show to colour based on tags and\r
+ flags\r
+Message-ID: <20120429230220.GO2704@mit.edu>\r
+References: <1335739697-8501-1-git-send-email-markwalters1009@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1335739697-8501-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFvrPIsWRmVeSWpSXmKPExsUixCmqrVt3Yq6/Qdt9I4vVc3ksrt+cyezA\r
+       5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZew8PpW1YBpPxZV1Qg2Mzzi7GDk5JARMJO5P\r
+       msUKYYtJXLi3nq2LkYtDSGAfo8SCZ8ugnA2MEheuPmWGcE4ySfzbsYgFwlnCKNE8cT9QPwcH\r
+       i4CqxJ3njCCj2AQ0JLbtXw5miwjoSNw+tIAdxGYWkJb49ruZCaRcWCBQ4t8vcZAwr4C2RMvc\r
+       /ywgYSEBD4n+Y2IQYUGJkzOfsEB0aknc+PcSrBNkyvJ/HCBhTgFPicc/vrOB2KICKhJTTm5j\r
+       m8AoNAtJ9ywk3bMQuhcwMq9ilE3JrdLNTczMKU5N1i1OTszLSy3SNdHLzSzRS00p3cQIDmdJ\r
+       /h2M3w4qHWIU4GBU4uEVyp3jL8SaWFZcmXuIUZKDSUmUt+LYXH8hvqT8lMqMxOKM+KLSnNTi\r
+       Q4wSHMxKIrza4kDlvCmJlVWpRfkwKWkOFiVxXjWtd35CAumJJanZqakFqUUwWRkODiUJ3rXH\r
+       gYYKFqWmp1akZeaUIKSZODhBhvMADT8FUsNbXJCYW5yZDpE/xagoJc7bB5IQAElklObB9cLS\r
+       zStGcaBXhHmnglTxAFMVXPcroMFMQIOZPGeBDC5JREhJNTAqV3Q92pifOsG9ii/oEmv/9tSK\r
+       u2vjrRnfVgu1XuyU2lY44cSOqkqf2vnrZyS/3X15mffUA9pcO+1Z/mmV5fRPblSYzq2pOO+j\r
+       8OnFspllm//ut2c9XLyc893RKu+EEvOzkWe3zJg2d49s84tio8pGiwwV7tc72V7+3sA+dWem\r
+       c8iynxKC1lOUWIozEg21mIuKEwEarODLEgMAAA==\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 29 Apr 2012 23:02:23 -0000\r
+\r
+I haven't really looked at this series yet, but I do have a quick\r
+high-level question.  Why use separate customization variables for the\r
+colors in search and show mode?  Wouldn't it make more sense to set\r
+the colors just once and use them in both modes?\r
+\r
+BTW, I like how this clearly distinguishes tags and flags.  I wonder\r
+if we could transition to flags for some information that's current\r
+shoe-horned into tags but actually represents immutable information\r
+about a message (attachment, signed, and encrypted or so).\r
+\r
+My one concern is that there's a common tag called "flagged", so this\r
+might be overloading terminology.\r
+\r
+Quoth Mark Walters on Apr 29 at 11:48 pm:\r
+> This is a rebased (but otherwise unchanged) version of\r
+> id:"1334431301-27303-1-git-send-email-markwalters1009@gmail.com".\r
+> \r
+> It's probably too late for 0.13 but in case anyone would like to look\r
+> at it this version applies cleanly to master so should be easier to\r
+> test.\r
+> \r
+> The first two patches are basically David Edmondson's patch\r
+> id:"1325006003-27152-1-git-send-email-dme@dme.org".\r
+> \r
+> Best wishes\r
+> \r
+> Mark\r
+> \r
+> \r
+> Mark Walters (3):\r
+>   emacs: Move colour line from search to lib\r
+>   emacs: Add `notmuch-show-line-faces' and apply it.\r
+>   emacs: allow notmuch-show-line-faces to use flags for colouring\r
+> \r
+>  emacs/notmuch-lib.el  |   18 ++++++++++++++++++\r
+>  emacs/notmuch-show.el |   44 ++++++++++++++++++++++++++++++++++++++++----\r
+>  emacs/notmuch.el      |   15 +--------------\r
+>  3 files changed, 59 insertions(+), 18 deletions(-)\r