Re: [PATCH v2 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

diff --git a/b7/a1f2be4fd5d2b9af7bf333dfedfcc69a746bd5 b/b7/a1f2be4fd5d2b9af7bf333dfedfcc69a746bd5
new file mode 100644 (file)
index 0000000..897a970
--- /dev/null
+++ b/b7/a1f2be4fd5d2b9af7bf333dfedfcc69a746bd5
@@ -0,0 +1,84 @@
+Return-Path: <novalazy@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 17A40431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 13 May 2013 06:53:52 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.099\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.099 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 0OI65rGjU-wO for <notmuch@notmuchmail.org>;\r
+       Mon, 13 May 2013 06:53:47 -0700 (PDT)\r
+Received: from mail-pd0-f174.google.com (mail-pd0-f174.google.com\r
+       [209.85.192.174]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 33DFF431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 13 May 2013 06:53:47 -0700 (PDT)\r
+Received: by mail-pd0-f174.google.com with SMTP id u10so4456310pdi.19\r
+       for <notmuch@notmuchmail.org>; Mon, 13 May 2013 06:53:45 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=x-received:date:message-id:from:to:cc:subject:in-reply-to\r
+       :references:mime-version:content-type:content-disposition\r
+       :content-transfer-encoding;\r
+       bh=KRSnQYQwCjiYZl16fLFkml1pbhCArpZ8GFNIUBvQu8I=;\r
+       b=PIIdv7EnSKUU+Ubg+WaHDJpwPTZGdvfAoDA59cpu6TUlWapDj22qF0HHaFVih6WWqx\r
+       OhW2FCjCcXi482P9Hfr2B/UwmJLIZwXdVWLpWqnbRaEFlpD9ORUur7YXVHfHcZAnZDXc\r
+       rFR12HpsstbY/EeKION0h2eX3DrlRcgVUnZL/GnzpbwpvbcVf/AIcebAVQFRMHebxO+Q\r
+       h3WTXONB4BIAe8XTqdBguJ14NaDyFYBDygZvt6+u2nHjo4m/MIpWCEt+bXIPvM9xpUVv\r
+       8zyw4mXaIiCdI/OX4EUIOWTYvVCRbfeqxrz1Ku77PxsbiZN4Ga12NiCHMVXVVNUmG2ls\r
+       VlvA==\r
+X-Received: by 10.68.100.98 with SMTP id ex2mr24918925pbb.19.1368453225326;\r
+       Mon, 13 May 2013 06:53:45 -0700 (PDT)\r
+Received: from localhost (215.42.233.220.static.exetel.com.au.\r
+       [220.233.42.215]) by mx.google.com with ESMTPSA id\r
+       br2sm14132896pbc.46.2013.05.13.06.53.42 for <multiple recipients>\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Mon, 13 May 2013 06:53:44 -0700 (PDT)\r
+Date: Mon, 13 May 2013 23:53:38 +1000\r
+Message-ID: <20130513235338.GA20690@hili.localdomain>\r
+From: Peter Wang <novalazy@gmail.com>\r
+To: David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH v2 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t\r
+In-Reply-To: <87zjw0la1n.fsf@zancas.localnet>\r
+References: <1368301809-12532-1-git-send-email-markwalters1009@gmail.com>\r
+       <1368301809-12532-8-git-send-email-markwalters1009@gmail.com>\r
+       <87zjw0la1n.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Disposition: inline\r
+Content-Transfer-Encoding: 8bit\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 13 May 2013 13:53:52 -0000\r
+\r
+On Sun, 12 May 2013 08:20:04 -0300, David Bremner <david@tethera.net> wrote:\r
+> Mark Walters <markwalters1009@gmail.com> writes:\r
+> \r
+> > -      notmuch_query_set_omit_excluded (query, NOTMUCH_EXCLUDE_FALSE);\r
+> > +      notmuch_query_set_omit_excluded (query, NOTMUCH_EXCLUDE_FLAG);\r
+> \r
+> Shouldn't the documentation be updated to cover NOTMUCH_EXCLUDE_FLAG?  I\r
+> realize it is not _wrong_ as written, but it is a bit confusing not to\r
+> cover all possible values of the enum.\r
+\r
+Actually, please drop patch 7 and patch 8.  It was wrong to combine the\r
+CLI-level EXCLUDE_* constants with the lib-level NOTMUCH_EXCLUDE_* constants.\r
+\r
+Peter\r