Move post-update hook to after all other activity
authorShawn O. Pearce <spearce@spearce.org>
Wed, 7 Mar 2007 21:50:24 +0000 (16:50 -0500)
committerJunio C Hamano <junkio@cox.net>
Wed, 7 Mar 2007 22:45:40 +0000 (14:45 -0800)
As the post-update hook is meant to run after we have completed the
receipt of the pushed changes, and it might actually try to kick off
a `repack -a -d`, we should delay on invoking it until after we have
removed the *.keep file on the uploaded pack (if we kept the pack).

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
receive-pack.c

index dda98549ca47bd1a253a22ca389eced5d95f11ef..d39aebac1e33be7b15b5662e464d93f00243cdc0 100644 (file)
@@ -206,12 +206,10 @@ static void run_update_post_hook(struct command *cmd)
 static void execute_commands(void)
 {
        struct command *cmd = commands;
-
        while (cmd) {
                update(cmd);
                cmd = cmd->next;
        }
-       run_update_post_hook(commands);
 }
 
 static void read_head_info(void)
@@ -456,6 +454,7 @@ int main(int argc, char **argv)
                        unlink(pack_lockfile);
                if (report_status)
                        report(unpack_status);
+               run_update_post_hook(commands);
        }
        return 0;
 }