--- /dev/null
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id F2AEE431FBC\r
+ for <notmuch@notmuchmail.org>; Fri, 25 May 2012 18:09:48 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id EeM0NtpnAJ6X for <notmuch@notmuchmail.org>;\r
+ Fri, 25 May 2012 18:09:47 -0700 (PDT)\r
+Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com\r
+ [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id C125A431FB6\r
+ for <notmuch@notmuchmail.org>; Fri, 25 May 2012 18:09:46 -0700 (PDT)\r
+Received: by lbbgk8 with SMTP id gk8so1123563lbb.26\r
+ for <notmuch@notmuchmail.org>; Fri, 25 May 2012 18:09:45 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+ :message-id:mime-version:content-type:content-transfer-encoding;\r
+ bh=M2p9nkOnWj+p4wH0fs8BDa4b/yVYgEN3+LRL6RuuVL0=;\r
+ b=uA2nrAvDMH2NJofFP41To2CXCuHf9bB1QsQUVwz3GF3zScGv5uyRbojBKYr3OFZNDo\r
+ H4klSg+XhQP0ztuKIuVxMhyxt4i7OohAmJLMLHWMfLp5/eLT7a8tEmNCHNsb2dAFemfI\r
+ yjy6Ulw+CNttiw5l/Z8tqlJbxn71uj0bRacbseHz5csEANZ7vONJFzScryTBGAqfqv4/\r
+ wtIwP6gVV2cWMoooQg/cUullE4kn1d5MmGd7YZ/yn145ngIl3/PmoJAp6uKL/6hD2rd8\r
+ +or2kRJ7oiz7cD9sxgrUFbuKeZyFVWHN7h4KIMk6PmcAILY2WIp10Y0Z2gPTrEa8jr3S\r
+ so5w==\r
+Received: by 10.152.148.34 with SMTP id tp2mr765889lab.47.1337994585206;\r
+ Fri, 25 May 2012 18:09:45 -0700 (PDT)\r
+Received: from localhost ([91.144.186.21])\r
+ by mx.google.com with ESMTPS id lv13sm6333203lab.8.2012.05.25.18.09.43\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Fri, 25 May 2012 18:09:44 -0700 (PDT)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Mike Kelly <pioto@pioto.org>\r
+Subject: Re: FreeBSD Support Patches\r
+In-Reply-To:\r
+ <CAFb0NsJ7Bv-Lp03WHvZQh_yaimzaj34VmkVQCjr_u5MDrfqAKw@mail.gmail.com>\r
+References: <1337953411-21000-1-git-send-email-pioto@pioto.org>\r
+ <87ipfktkgy.fsf@gmail.com>\r
+ <CAFb0NsJ7Bv-Lp03WHvZQh_yaimzaj34VmkVQCjr_u5MDrfqAKw@mail.gmail.com>\r
+User-Agent: Notmuch/0.13+30~g6d44c5a (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 26 May 2012 05:07:36 +0400\r
+Message-ID: <87aa0vu4vb.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 26 May 2012 01:09:49 -0000\r
+\r
+Mike Kelly <pioto@pioto.org> writes:\r
+\r
+> On Fri, May 25, 2012 at 10:15 AM, Dmitry Kurochkin\r
+> <dmitry.kurochkin@gmail.com> wrote:\r
+>> Why do we need to explicitly declare Emacs dependency for tests? =C2=A0T=\r
+here\r
+>> should be no need for it. =C2=A0We have "implicit" dependencies which are\r
+>> declared once (see test_declare_external_prereq calls at the end of\r
+>> test-lib.sh) and are automatically handled when a test tries to use a\r
+>> missing binary. =C2=A0Explicit dependencies are hard to maintain (e.g. y=\r
+our\r
+>> patch adds explicit emacs dependency for crypto test but misses gpg).\r
+>> With rare exceptions we should not use explicit dependencies.\r
+>\r
+> Because not every test actually has those implicit dependencies. For\r
+> example, some of the crypto tests depend upon emacs_deliver_message\r
+> working correctly for subsequents tests. Those emacs_deliver_message\r
+> tests are skipped, but not the ones after it that try to do something\r
+> with that injected message.\r
+>\r
+> For the emacs-* test files, there are some tests that act the same\r
+> way.\r
+\r
+These subtests do not directly depend on Emacs. They depend on other\r
+subtests. Currently, we do not support such dependencies. But what you\r
+propose is not the solution. We have two options here: make all\r
+subtests independent or introduce proper subtests dependencies. The\r
+former might require many changes to existing tests and may be hard to\r
+enforce. The latter is not trivial as well but is doable. I planned to\r
+implement subtests dependencies but never really got to it (and I do not\r
+think I will anytime soon).\r
+\r
+> However, it is also a minor speed improvement to say that,\r
+> obviously, none of the emacs tests are going to work, so just don't\r
+> bother.\r
+>\r
+\r
+I do not think maintaining an explicit list of dependencies worth a\r
+minor speed improvement.\r
+\r
+Given all above, I understand that your patches fix a common problem in\r
+a simple way. And it does not look like we would get proper solution\r
+anytime soon. So I am ok with these patches with two comments:\r
+\r
+ * Provide a proper commit message to explain the issue in more detail.\r
+\r
+ * Add an XXX comment for each explicit dependency, something like:\r
+\r
+ // XXX: Workaround for subtests that depend on other subtests (and,\r
+ // hence, indirectly depend on emacs). Should be removed when we\r
+ // have proper subtests dependencies.\r
+\r
+Regards,\r
+ Dmitry\r
+\r
+> --=20\r
+> Mike Kelly\r
projects / notmuch-archives.git / commitdiff