Re: [PATCH] bindings: drop build time message on missing ruby dependency

diff --git a/96/bc3a0705bcaa655e593d228b94975a7d08eed1 b/96/bc3a0705bcaa655e593d228b94975a7d08eed1
new file mode 100644 (file)
index 0000000..a7963c2
--- /dev/null
+++ b/96/bc3a0705bcaa655e593d228b94975a7d08eed1
@@ -0,0 +1,104 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 54CAB6DE014D\r
+ for <notmuch@notmuchmail.org>; Thu, 14 Apr 2016 03:27:14 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.615\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.615 tagged_above=-999 required=5 tests=[AWL=-0.037,\r
+  SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id EAtWzXw5qdZz for <notmuch@notmuchmail.org>;\r
+ Thu, 14 Apr 2016 03:27:05 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 8214B6DE0127\r
+ for <notmuch@notmuchmail.org>; Thu, 14 Apr 2016 03:27:05 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id A8B04100090;\r
+ Thu, 14 Apr 2016 13:26:58 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] bindings: drop build time message on missing ruby\r
+ dependency\r
+In-Reply-To: <1460570925-12101-1-git-send-email-jani@nikula.org>\r
+References: <1460570925-12101-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.21+99~g7cbc880 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 14 Apr 2016 13:26:58 +0300\r
+Message-ID: <m2inzktril.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 14 Apr 2016 10:27:14 -0000\r
+\r
+On Wed, Apr 13 2016, Jani Nikula <jani@nikula.org> wrote:\r
+\r
+\r
+LGTM.\r
+\r
+Tomi\r
+\r
+\r
+> The usual make message on everything being up to date is:\r
+>\r
+>      make: Nothing to be done for 'all'.\r
+>\r
+> However, since\r
+>\r
+> commit d038b9320949c79503fe4b76870aaabf279405ab\r
+> Author: David Bremner <david@tethera.net>\r
+> Date:   Mon Jun 1 09:08:59 2015 +0200\r
+>\r
+>     build: integrate building ruby bindings into notmuch build process\r
+>\r
+> if one doesn't have the ruby dependencies installed, the message has\r
+> been:\r
+>\r
+>      Missing dependency, skipping ruby bindings\r
+>\r
+> Restore the usual behaviour by dropping the message. It's redundant\r
+> during build anyway, since the configure script already outputs:\r
+>\r
+>      Checking for ruby development files... No (skipping ruby bindings)\r
+> ---\r
+>  bindings/Makefile.local | 2 --\r
+>  1 file changed, 2 deletions(-)\r
+>\r
+> diff --git a/bindings/Makefile.local b/bindings/Makefile.local\r
+> index 4ecf839d7c18..11d11d4bcbeb 100644\r
+> --- a/bindings/Makefile.local\r
+> +++ b/bindings/Makefile.local\r
+> @@ -10,8 +10,6 @@ ifeq ($(HAVE_RUBY_DEV),1)\r
+>              LIBNOTMUCH="../../lib/$(LINKER_NAME)" \\r
+>              ruby extconf.rb --vendor\r
+>      $(MAKE) -C $(dir)/ruby\r
+> -else\r
+> -    @echo Missing dependency, skipping ruby bindings\r
+>  endif\r
+>  \r
+>  CLEAN += $(patsubst %,$(dir)/ruby/%, \\r
+> -- \r
+> 2.1.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> https://notmuchmail.org/mailman/listinfo/notmuch\r