Re: [Patch v2 1/4] nmbug: use dump --format=batch-tag

diff --git a/9e/1155482cbe4644ef7e011007f83fb71ae807b9 b/9e/1155482cbe4644ef7e011007f83fb71ae807b9
new file mode 100644 (file)
index 0000000..bbe434c
--- /dev/null
+++ b/9e/1155482cbe4644ef7e011007f83fb71ae807b9
@@ -0,0 +1,120 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2B70A431FB6\r
+       for <notmuch@notmuchmail.org>; Thu, 21 Feb 2013 04:23:01 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id XjtF4rQ2vQFw for <notmuch@notmuchmail.org>;\r
+       Thu, 21 Feb 2013 04:22:59 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id C6FEB431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 21 Feb 2013 04:22:59 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id A53AB10014F;\r
+       Thu, 21 Feb 2013 14:22:42 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [Patch v2 1/4] nmbug: use dump --format=batch-tag\r
+In-Reply-To: <87k3q151fx.fsf@zancas.localnet>\r
+References: <1361399077-7737-1-git-send-email-david@tethera.net>\r
+       <1361399077-7737-2-git-send-email-david@tethera.net>\r
+       <m27gm2ax1k.fsf@guru.guru-group.fi>\r
+       <87k3q151fx.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.15.2+41~g0ce9bd4 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 21 Feb 2013 14:22:42 +0200\r
+Message-ID: <m2y5ehvotp.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 21 Feb 2013 12:23:01 -0000\r
+\r
+On Thu, Feb 21 2013, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>>\r
+>> This patch series looks good to me (as far as I can understand, I did\r
+>> not find the "silly bug" in your previous patch...)\r
+>>\r
+>\r
+> Compare :\r
+>\r
+> +    print $notmuch $A_action.$TAGPREFIX.$pair->{tag}, " -- ",\r
+> +      'id:'.$pair->{id};\r
+>\r
+> vs.\r
+>\r
+> +    print $notmuch $D_action.$TAGPREFIX.$pair->{tag},\r
+> +      'id:'.$pair->{id};\r
+\r
+Ah, ok :)\r
+\r
+> I obviously did not test that version very well.\r
+\r
+IIRC that has happened to some other people, too ;(\r
+\r
+>> Instead of mentioning that "calls are _not_ passed to shell" here,\r
+>> that could be briefly mentioned just before system() calls in the\r
+>> script -- and that definitely should not be 'At the moment' feature.\r
+>\r
+> Sure, the "At the moment" is meant to modify "relies". In the next\r
+> patch, we stop relying on this feature of Perl.\r
+\r
+Well, one have to expect the execution to happen one way or another\r
+(and arrange quoting accordingly); for example:\r
+\r
+$ echo; perl -e 'exec q/echo "foobar"/'\r
+\r
+foobar\r
+\r
+vs.\r
+\r
+$ echo; perl -e 'exec qw/echo "foobar"/'\r
+\r
+"foobar"\r
+\r
+first gave exec one arg, 'echo "foobar"' and due to "":s perl used sh\r
+to execute it, second gave exec list [ 'echo', '"foobar"' ] and therefore\r
+echo got foobar with quotes as a command line argument.\r
+\r
+Anyone interested for more information, see 'perldoc -f exec'.\r
+\r
+\r
+>> the system() function in perl(1) never pass execution through the\r
+>> shell in case the args are list more than one arg:\r
+>\r
+> right. that's what I meant by "is a documented feature of perl's system\r
+> function"\r
+>\r
+> So I think we mean to say the same thing here; but I could I add a\r
+> comment in this patch (to delete it in the next). Or maybe reword that\r
+> commit message somehow.\r
+\r
+Yes, the message is the same, just that there should not be need for that..\r
+\r
+> d\r
+\r
+Tomi\r