Re: [RFC PATCH] configure: check for POSIX.1-2008 realpath(3) implementation.

diff --git a/f6/7c367bff1139d3d5dce45ebca59c645f473bae b/f6/7c367bff1139d3d5dce45ebca59c645f473bae
new file mode 100644 (file)
index 0000000..8803b81
--- /dev/null
+++ b/f6/7c367bff1139d3d5dce45ebca59c645f473bae
@@ -0,0 +1,100 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id AAAC1431FBD\r
+       for <notmuch@notmuchmail.org>; Sun, 26 Jan 2014 03:18:24 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ec3QXsHvpZx1 for <notmuch@notmuchmail.org>;\r
+       Sun, 26 Jan 2014 03:18:17 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 38286431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 26 Jan 2014 03:18:17 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id E3188100051;\r
+       Sun, 26 Jan 2014 13:18:12 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [RFC PATCH] configure: check for POSIX.1-2008 realpath(3)\r
+       implementation.\r
+In-Reply-To: <871tzvo92w.fsf@zancas.localnet>\r
+References: <1390687142-16401-1-git-send-email-tomi.ollila@iki.fi>\r
+       <871tzvo92w.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.17+41~g8e7fabf (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 26 Jan 2014 13:18:12 +0200\r
+Message-ID: <m2fvobuh3f.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 26 Jan 2014 11:18:24 -0000\r
+\r
+On Sun, Jan 26 2014, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>> +#if POSIX_2008_REALPATH\r
+>>      filename = realpath (config->filename, NULL);\r
+>> +#else\r
+>> +    /* compatibility with minor effort, not elegance, is the ruling factor\r
+>> +       in these (two) else branches... */\r
+>> +    char resolved_path[PATH_MAX];\r
+>> +    filename = realpath (config->filename, resolved_path);\r
+>> +#endif\r
+\r
+\r
+>\r
+> I worry a bit about making the mainline code messier and harder to maintain, in order to\r
+> accomodate an unknown number of targets without POSIX2008 realpath. Do\r
+> we know how widespread this problem is? Is it just NetBSD?\r
+>\r
+> I looked at borrowing realpath from gnulib; it looks like it would be a\r
+> bit of work as the least complicated version includes 3 other include\r
+> files. But then the mainline code could be blisfully ignorant of the\r
+> whole dispute.\r
+\r
+We could also create\r
+\r
+char * realpath2008 (const char * path, char * resolved_path)\r
+{\r
+        if (resolved_path == NULL) {\r
+               resolved_path = malloc (MAX_PATH);\r
+                if (resolved_path == NULL)\r
+                       return NULL;\r
+        }\r
+        return realpath (path, resolved_path);\r
+}\r
+        \r
+And, in the case where NULL argument is accepted, \r
+\r
+#define realpath2008(path, resolved_path) realpath(path, resolved_path) \r
+\r
+(or an inline function to do the same)\r
+\r
+In this case one is not totally ignorant to the whole dispute -- but\r
+on the other hand, developer should be savvy about the potential \r
+issues using realpath() function, and this might just ring the bell...\r
+\r
+> d\r
+\r
+Tomi\r