Re: [PATCH 4/4] setup: prompt user for search.exclude_tags value

diff --git a/2c/2835653d7d225a495477fdfd48f427fb411584 b/2c/2835653d7d225a495477fdfd48f427fb411584
new file mode 100644 (file)
index 0000000..565cc6f
--- /dev/null
+++ b/2c/2835653d7d225a495477fdfd48f427fb411584
@@ -0,0 +1,89 @@
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 822BA429E54\r
+       for <notmuch@notmuchmail.org>; Sat, 21 Jan 2012 22:56:59 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id M9GAWPbOfrlH for <notmuch@notmuchmail.org>;\r
+       Sat, 21 Jan 2012 22:56:59 -0800 (PST)\r
+Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com\r
+       [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id F2220429E40\r
+       for <notmuch@notmuchmail.org>; Sat, 21 Jan 2012 22:56:58 -0800 (PST)\r
+Received: by wibhr12 with SMTP id hr12so1764507wib.26\r
+       for <notmuch@notmuchmail.org>; Sat, 21 Jan 2012 22:56:57 -0800 (PST)\r
+Received: by 10.180.106.202 with SMTP id gw10mr9019454wib.3.1327215417827;\r
+       Sat, 21 Jan 2012 22:56:57 -0800 (PST)\r
+Received: from localhost ([109.131.97.13])\r
+       by mx.google.com with ESMTPS id gy6sm6346223wib.11.2012.01.21.22.56.56\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sat, 21 Jan 2012 22:56:57 -0800 (PST)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH 4/4] setup: prompt user for search.exclude_tags value\r
+In-Reply-To: <20120120041902.GV16740@mit.edu>\r
+References: <1326586654-16840-3-git-send-email-amdragon@mit.edu>\r
+       <1327000744-25463-1-git-send-email-pieter@praet.org>\r
+       <1327000744-25463-5-git-send-email-pieter@praet.org>\r
+       <20120119194437.GP16740@mit.edu> <8762g7o0k4.fsf@praet.org>\r
+       <20120120041902.GV16740@mit.edu>\r
+User-Agent: Notmuch/0.11+101~g94bf862 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+Date: Sun, 22 Jan 2012 07:55:05 +0100\r
+Message-ID: <87ipk4446u.fsf@praet.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 22 Jan 2012 06:56:59 -0000\r
+\r
+On Thu, 19 Jan 2012 23:19:02 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> [...]\r
+> Hah, okay.  How about this as an initial minor refactoring of the code\r
+> for new.tags?\r
+> [...]\r
+\r
+Great, thanks!\r
+\r
+\r
+Would the following commit message be satisfactory? :\r
+\r
+  #+begin_quote\r
+    setup: move tag printing and parsing into separate functions\r
+\r
+    * notmuch-setup.c (notmuch_setup_command):\r
+      Break tag printing and response parsing out into separate functions\r
+      called `print_tag_list' respectively `parse_tag_list', for reuse\r
+      with the 'search.exclude_tags' option.\r
+  #+end_quote\r
+\r
+(if not, please suggest an alternative; it'll be your name at the top)\r
+\r
+\r
+Thanks again!\r
+\r
+\r
+Peace\r
+\r
+-- \r
+Pieter\r